fix(VColorPicker): don't display 0 alpha as 1 #17323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErKeLost
changed the title
ErKeLost
changed the title
KaelWD
approved these changes
May 9, 2023
KaelWD
added
T: bug
KaelWD
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed logic that causes the value to become 1 if colorpicker alpha slider slides to the leftmost and causes value to be 0 to form false.
We should only judge the
undefinedandnulltypes because0is a valid value for colorpicker, not false.The solution is to use
! =to judge onlyundefinedandnullto make0a valid valueclosed #17322