Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCarousel): fix carousel direction props #17587

Merged

Conversation

SonTT19
Copy link
Contributor

@SonTT19 SonTT19 commented Jun 12, 2023

Description

fixes #17586

Markup:

<template>
  <v-app>
    <v-container>
      <v-carousel direction="vertical">
        <v-carousel-item
          src="https://cdn.vuetifyjs.com/images/cards/docks.jpg"
          cover
        />
        <v-carousel-item
          src="https://cdn.vuetifyjs.com/images/cards/hotel.jpg"
          cover
        />
        <v-carousel-item
          src="https://cdn.vuetifyjs.com/images/cards/sunshine.jpg"
          cover
        />
      </v-carousel>

      <v-carousel>
        <v-carousel-item
          src="https://cdn.vuetifyjs.com/images/cards/docks.jpg"
          cover
        />
        <v-carousel-item
          src="https://cdn.vuetifyjs.com/images/cards/hotel.jpg"
          cover
        />
        <v-carousel-item
          src="https://cdn.vuetifyjs.com/images/cards/sunshine.jpg"
          cover
        />
      </v-carousel>
    </v-container>
  </v-app>
</template>

Copy link
Member

@KaelWD KaelWD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should use filterProps() like other components do.

@SonTT19 SonTT19 requested a review from KaelWD June 16, 2023 04:41
@SonTT19 SonTT19 requested a review from johnleider July 5, 2023 10:18
@johnleider johnleider added this to the v3.3.x milestone Jul 5, 2023
@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VCarousel VCarousel labels Jul 5, 2023
@johnleider johnleider enabled auto-merge (squash) July 5, 2023 15:27
@johnleider johnleider disabled auto-merge July 11, 2023 21:50
@johnleider johnleider merged commit 8a461e2 into vuetifyjs:master Jul 11, 2023
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VCarousel VCarousel T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report][3.3.3] Setting the direction prop to vertical on the carousel does not work
3 participants