-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(VCard): workaround to allow content to overflow, fixes #17593, #17628 #17839
docs(VCard): workaround to allow content to overflow, fixes #17593, #17628 #17839
Conversation
I don't think that we need an example for this. Just a mention in the guide with links to the corresponding issues. |
@johnleider Is the text in the guide sufficient as it is, only the example should be removed? Also I don't think these two issues are perfectly representative of this happy-path scenario (one is related to Personally I feel like the text
may get misunderstood by beginners, as it mentions two new concepts that require a specific setup to replicate. For example, there is a parallel More importantly, I also intended this example to be a manual test coverage of the current behavior, so that whenever the scenario or workarounds change (due to any breaking change, a bug, or when new edge cases get discovered -- I'm not confident if this is an exhaustive list of all possible overflow issues, and given the different implementation compared to Vuetify 2, there can be other side-effects), it will be updated as a source of truth for any overflow scenarios. But I can't find any better place for this than a guide. I'd prefer at least linking a |
14ec12d
to
b8a4f81
Compare
Updated PR with a less intrusive |
I'm not sure how the other @vuetifyjs/core-team feel about this but I don't think this belongs in the docs. |
would agree with @johnleider. Like he had said initially, just the mention in the upgrade guide with corresponding issue links should suffice. |
Moved both issue links to the upgrade guide and removed the example. |
@@ -75,6 +75,10 @@ In some cases it is possible to combine the different options, like the example | |||
|
|||
<example file="v-card/basics-combine" /> | |||
|
|||
### Content overflow | |||
|
|||
By default, `v-card` doesn't let its content overflow outside the card. It also creates a `z-index` stacking context, making its content unable to display on top of elements outside `v-card` even if it defines a higher `z-index` value. If you want to opt-out from this behavior, you can use it like `<v-card style="overflow: initial; z-index: initial">`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By default, `v-card` doesn't let its content overflow outside the card. It also creates a `z-index` stacking context, making its content unable to display on top of elements outside `v-card` even if it defines a higher `z-index` value. If you want to opt-out from this behavior, you can use it like `<v-card style="overflow: initial; z-index: initial">`. | |
`v-card` does not allow its content to overflow outside the card by default. It also establishes a z-index stacking context, which prevents its content from displaying on top of elements outside the `v-card`, even when it sets a higher z-index value. To override this default behavior, apply the following usage: `<v-card style="overflow: initial; z-index: initial">`. |
|
||
### v-card | ||
|
||
- Content is no longer allowed to overflow card or use higher `z-index` values to display on top of elements outside the card. To disable this behavior, use `<v-card style="overflow: initial; z-index: initial">` ([#17593](https://github.com/vuetifyjs/vuetify/issues/17593), [#17628](https://github.com/vuetifyjs/vuetify/issues/17628)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Content is no longer allowed to overflow card or use higher `z-index` values to display on top of elements outside the card. To disable this behavior, use `<v-card style="overflow: initial; z-index: initial">` ([#17593](https://github.com/vuetifyjs/vuetify/issues/17593), [#17628](https://github.com/vuetifyjs/vuetify/issues/17628)) | |
- `v-card` does not allow content to overflow or use higher `z-index` values to display on top of elements outside the it. To disable this behavior, use `<v-card style="overflow: initial; z-index: initial">` ([#17593](https://github.com/vuetifyjs/vuetify/issues/17593), [#17628](https://github.com/vuetifyjs/vuetify/issues/17628)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"on top of elements outside the it", I assume it'll be "outside it" right?
Description
Add an upgrade step for
v-card
to allow a content to overflow the card by addingstyle="overflow: initial"
as perAlso document a fix for
z-index
stacking context behavior by addingstyle="z-index: initial"
as perCreate a Content overflow section under
v-card
documentation with an explanation of the default behavior, and an interactive example of how to disable it using both of these styles.