Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtn): Override hover effect for disable state #17912

Conversation

prashantsinghb
Copy link
Contributor

fixes #17228

Description

Override hover effect for disable state

Markup:

<template>
  <v-sheet class="mx-auto" max-width="600">
    <v-container>
      <v-data-table
        :items="desserts"
        :headers="headers"
        :items-per-page="itemsPerPage"
      />
    </v-container>
  </v-sheet>
</template>
<script>
export default {
    data: () => ({
      itemsPerPage: 2,
      headers: [
        {
          title: "Dessert (100g serving)",
          align: "start",
          sortable: false,
          key: "name"
        },
        { title: "Calories", align: "end", key: "calories" },
        { title: "Fat (g)", align: "end", key: "fat" },
        { title: "Carbs (g)", align: "end", key: "carbs" },
        { title: "Protein (g)", align: "end", key: "protein" },
        { title: "Iron (%)", align: "end", key: "iron" }
      ],
      desserts: [
        {
          name: "Frozen Yogurt",
          calories: 159,
          fat: 6.0,
          carbs: 24,
          protein: 4.0,
          iron: "1"
        },
        {
          name: "Jelly bean",
          calories: 375,
          fat: 0.0,
          carbs: 94,
          protein: 0.0,
          iron: "0"
        },
        {
          name: "KitKat",
          calories: 518,
          fat: 26.0,
          carbs: 65,
          protein: 7,
          iron: "6"
        },
        {
          name: "Eclair",
          calories: 262,
          fat: 16.0,
          carbs: 23,
          protein: 6.0,
          iron: "7"
        },
        {
          name: "Gingerbread",
          calories: 356,
          fat: 16.0,
          carbs: 49,
          protein: 3.9,
          iron: "16"
        },
        {
          name: "Ice cream sandwich",
          calories: 237,
          fat: 9.0,
          carbs: 37,
          protein: 4.3,
          iron: "1"
        },
        {
          name: "Lollipop",
          calories: 392,
          fat: 0.2,
          carbs: 98,
          protein: 0,
          iron: "2"
        },
        {
          name: "Cupcake",
          calories: 305,
          fat: 3.7,
          carbs: 67,
          protein: 4.3,
          iron: "8"
        },
        {
          name: "Honeycomb",
          calories: 408,
          fat: 3.2,
          carbs: 87,
          protein: 6.5,
          iron: "45"
        },
        {
          name: "Donut",
          calories: 452,
          fat: 25.0,
          carbs: 51,
          protein: 4.9,
          iron: "22"
        }
      ]
    }),
  }
</script>

Copy link
Member

@johnleider johnleider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Disabled buttons have no pointer events so this shouldn't have an effect anyways. Looking at your example I'm not seeing the problem. Can you make a gif?

@prashantsinghb
Copy link
Contributor Author

@johnleider - Issue is mobile screen specific.

Issue:

screen-capture.1.webm.mp4

After Fix

screen-capture.webm.mp4

@johnleider johnleider added T: bug Functionality that does not work as intended/expected C: VBtn VBtn labels Aug 8, 2023
@johnleider johnleider added this to the v3.3.x milestone Aug 8, 2023
@johnleider johnleider merged commit e5ddab5 into vuetifyjs:master Aug 8, 2023
10 checks passed
@prashantsinghb prashantsinghb deleted the fix/17228-VPagination-arrow-stuck-active-in-mobile branch August 9, 2023 05:09
prashantsinghb added a commit to prashantsinghb/vuetify that referenced this pull request Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VBtn VBtn T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants