Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): update Norwegian translations #17988

Merged
merged 2 commits into from
Aug 8, 2023

Conversation

Bjornar97
Copy link
Contributor

@Bjornar97 Bjornar97 commented Aug 8, 2023

Description

Add some missing translation in locale/no, in sections datePicker, pagination, stepper, rating, loading and infiniteScroll

datePicker, pagination, stepper, rating, loading and infiniteScroll
@KaelWD
Copy link
Member

KaelWD commented Aug 8, 2023

@rosvik @marduv Review please

Copy link
Contributor

@rosvik rosvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍 Have one tiny suggestion on the date picker translations.

packages/vuetify/src/locale/no.ts Outdated Show resolved Hide resolved
@Bjornar97 Bjornar97 requested a review from rosvik August 8, 2023 11:26
Copy link
Contributor

@rosvik rosvik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bjornar97 I don't have permissions to approve PRs, but would if I could. Looks great ✅

@KaelWD KaelWD added this to the v3.3.x milestone Aug 8, 2023
@KaelWD KaelWD changed the title fix(locale): update no translations fix(locale): update Norwegian translations Aug 8, 2023
@KaelWD KaelWD merged commit c6bb099 into vuetifyjs:master Aug 8, 2023
8 of 10 checks passed
prashantsinghb pushed a commit to prashantsinghb/vuetify that referenced this pull request Aug 9, 2023
@marduv
Copy link
Contributor

marduv commented Aug 9, 2023

Just a minor thing I can see is: to should be til

dateRangeInput: {
    divider: 'to',
},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants