Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VDatePicker): add isBeforeYear check #19141

Merged
merged 4 commits into from Mar 6, 2024

Conversation

Fo00oX
Copy link
Contributor

@Fo00oX Fo00oX commented Jan 31, 2024

Description

Add missing IUtil interface function: isBeforeYear

Markup:

<template>
  <v-app>
    <div class="ma-4 pa-4">
      {{ adapter.date() }}
    </div>
  </v-app>
</template>

<script setup>
  import { useDate } from '../src/composables/date'

  const adapter = useDate()

  console.log(adapter)
</script>

@Fo00oX Fo00oX added the C: VDatePicker VDatePicker label Jan 31, 2024
@Fo00oX Fo00oX self-assigned this Jan 31, 2024
@Fo00oX Fo00oX force-pushed the feat/v-date-picker-is-before-year-check branch from fc00bd1 to 14fd0bd Compare January 31, 2024 21:20
@Fo00oX Fo00oX closed this Jan 31, 2024
@Fo00oX Fo00oX reopened this Jan 31, 2024
@Fo00oX Fo00oX force-pushed the feat/v-date-picker-is-before-year-check branch 2 times, most recently from a83312d to 9bdac75 Compare January 31, 2024 22:15
@johnleider johnleider force-pushed the feat/v-date-picker-is-before-year-check branch 2 times, most recently from b82ab17 to 693ba08 Compare January 31, 2024 22:22
@johnleider johnleider force-pushed the feat/v-date-picker-is-before-year-check branch from d739a27 to b1f3afe Compare February 1, 2024 20:32
@KaelWD
Copy link
Member

KaelWD commented Feb 6, 2024

The built-in adapter is only supposed to support what is needed for our calendar components, we might as well just pull all in of date-fns otherwise.

@johnleider
Copy link
Member

@blalan Of the new implementations, which would be useful to you to keep?

@blalan05
Copy link
Member

blalan05 commented Feb 6, 2024

Dealing with Events, I'd say isAfterDay is the only one I might need, for those multi-day/allDay events.

@johnleider johnleider added this to the v3.6.0 (Nebula) milestone Feb 6, 2024
@johnleider johnleider added the T: feature A new feature label Feb 6, 2024
@johnleider johnleider modified the milestones: v3.6.0 (Nebula), v3.5.x Feb 6, 2024
@Fo00oX Fo00oX force-pushed the feat/v-date-picker-is-before-year-check branch from 400e31e to 4030383 Compare February 6, 2024 19:40
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from cd170f8 to 98e57dc Compare February 14, 2024 06:14
johnleider
johnleider previously approved these changes Mar 6, 2024
@johnleider johnleider changed the base branch from master to dev March 6, 2024 00:05
@johnleider johnleider dismissed their stale review March 6, 2024 00:05

The base branch was changed.

@johnleider johnleider merged commit a6a02f0 into dev Mar 6, 2024
17 of 18 checks passed
@johnleider johnleider deleted the feat/v-date-picker-is-before-year-check branch March 6, 2024 00:06
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Mar 13, 2024
Co-authored-by: John Leider <john@vuetifyjs.com>
VIXI0 pushed a commit to VIXI0/vuetify that referenced this pull request Mar 20, 2024
Co-authored-by: John Leider <john@vuetifyjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VDatePicker VDatePicker T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants