Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VField): ensure label is reversed when reverse prop is used #19214

Merged
merged 1 commit into from Feb 21, 2024

Conversation

yuwu9145
Copy link
Member

@yuwu9145 yuwu9145 commented Feb 13, 2024

Fixes the issue that labels are not reversed when reverse prop is used.

It happens to "underlined" & "outlined" variants as their labels are inside "v-field__outline"

Screenshot 2024-02-13 at 7 01 07 pm

Markup:

<template>
  <v-app>
    <v-container>
      <v-text-field
        label="File input"
        reverse
        variant="underlined"
        model-value="test"
      />
      <v-text-field
        label="File input"
        reverse
        variant="outlined"
        model-value="test"
      />
      <v-text-field
        label="File input"
        reverse
        variant="filled"
        model-value="test"
      />
      <v-text-field
        label="Solo"
        reverse
        variant="solo"
        model-value="test"
      />
    </v-container>
  </v-app>
</template>


@MajesticPotatoe MajesticPotatoe added T: bug Functionality that does not work as intended/expected C: VField labels Feb 13, 2024
@KaelWD KaelWD force-pushed the master branch 3 times, most recently from cd170f8 to 98e57dc Compare February 14, 2024 06:14
@johnleider johnleider added this to the v3.5.x milestone Feb 14, 2024
@johnleider johnleider merged commit 1407128 into master Feb 21, 2024
17 of 19 checks passed
@johnleider johnleider deleted the fix-reverse-label branch February 21, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VField T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants