Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSelectionContolGroup): add correct ripple prop type #19465

Conversation

EvgenyWas
Copy link
Contributor

@EvgenyWas EvgenyWas commented Mar 25, 2024

Description

fixes #19462

Markup:

packages/vuetify/dev/Playground.vue

<template>
  <v-app>
    <v-container>
      <v-switch />
      <v-checkbox />
      <v-radio-group />
      <v-radio />
    </v-container>
  </v-app>
</template>

<script>
  export default {
    name: 'Playground',
  }
</script>

packages/vuetify/dev/vuetify/defaults.js

export default {
  global: {
    ripple: { class: "text-error" },
  },
};

@johnleider johnleider added this to the v3.5.x milestone Mar 26, 2024
@johnleider johnleider added T: bug Functionality that does not work as intended/expected D: ripple labels Mar 26, 2024
@johnleider johnleider merged commit 12cc8cc into vuetifyjs:master Mar 26, 2024
10 checks passed
@EvgenyWas EvgenyWas deleted the fix/19462-vue-warn-invalid-prop-ripple-expected-boolean-got-object branch March 26, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: ripple T: bug Functionality that does not work as intended/expected
Projects
None yet
2 participants