New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VMenu): Vmenu does not restore focus on enter #19519
Merged
johnleider
merged 13 commits into
vuetifyjs:master
from
elkofy:fix/19206-v-menu-does-not-restore-focus-on-enter
Apr 8, 2024
Merged
fix(VMenu): Vmenu does not restore focus on enter #19519
johnleider
merged 13 commits into
vuetifyjs:master
from
elkofy:fix/19206-v-menu-does-not-restore-focus-on-enter
Apr 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elkofy
changed the title
Fix(VMenu) : Vmenu does not restore focus on enter
Fix(VMenu): Vmenu does not restore focus on enter
Mar 31, 2024
elkofy
changed the title
Fix(VMenu): Vmenu does not restore focus on enter
fix(VMenu): Vmenu does not restore focus on enter
Apr 1, 2024
This has weird behavior when you tab into the first input and hit enter. |
MajesticPotatoe
added
T: bug
Functionality that does not work as intended/expected
C: VMenu
VMenu
labels
Apr 2, 2024
johnleider
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VMenu didn't restore the activators focus on Enter
Description
i added a new condition if the key pressed is Enter and the closeOnContentClick props is disabled.
This change enhanced the use case for vmenu to be used inside forms.
Describe your changes in detail. Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.
fixes #19206
Markup:
packages/vuetify/dev/Playground.vue