Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Setting active tab after removing an tab from array causes selection offset #4735

Closed
MajesticPotatoe opened this issue Jul 27, 2018 · 2 comments
Assignees
Labels
T: bug Functionality that does not work as intended/expected
Milestone

Comments

@MajesticPotatoe
Copy link
Member

Versions and Environment

Vuetify: 1.1.8
Vue: 2.5.16
Browsers: Chrome v68
OS: Windows 10

Steps to reproduce

Click on an X button to close a tab. (as noted below, closing the last tab functions properly)

Expected Behavior

The tab should close and the last tab should be selected.

Actual Behavior

The slider bar selects the correct tab However the active tab is the 1 index behind. When clicking the tab with the slider, it behaves as if it was the active tab (nothing happens).

Reproduction Link

https://codepen.io/MajesticPotatoe/pen/rrGoEG


Additional Comments:

This behavior does not happen when iterating through active tabs (like in docs) or if you remove the last tab. Have also tried doing async/await but everything seems to debug as if its functioning normally.

One thing to note that may need a new ticket is that if you remove all of the tabs from the array, the slider bar still remains.

@MajesticPotatoe MajesticPotatoe changed the title Setting active tab after removing an tab from array causes selection offset [Bug Report] Setting active tab after removing an tab from array causes selection offset Jul 27, 2018
@johnleider johnleider added the pending review The issue is still pending disposition label Aug 7, 2018
@tony-thomas-git
Copy link

tony-thomas-git commented Oct 1, 2018

Possibly related. Closing all tabs leaves GUI artifacts.

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected and removed pending review The issue is still pending disposition labels Dec 4, 2018
@johnleider johnleider mentioned this issue Feb 26, 2019
8 tasks
@johnleider johnleider self-assigned this Mar 4, 2019
@johnleider johnleider added this to the v2.0.0 milestone Mar 4, 2019
@johnleider
Copy link
Member

Fixed in f22d754

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

4 participants