Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] Nuxt -- theme: false wipes html head elements #4958

Closed
zerosym opened this issue Aug 25, 2018 · 2 comments
Closed

[Bug Report] Nuxt -- theme: false wipes html head elements #4958

zerosym opened this issue Aug 25, 2018 · 2 comments
Assignees
Labels
T: bug Functionality that does not work as intended/expected upstream Problem with a third party library that we may have to work around
Milestone

Comments

@zerosym
Copy link

zerosym commented Aug 25, 2018

Versions and Environment

Vuetify: Latest
Vue: Latest
Browsers: Any
OS: Any

Doing the following in Nuxt causes Nuxt to wipe all elements with data-n-head attributes.

Vue.use(Vuetify, {
  theme: false,
})

Example

theme: {...}
normal

theme: false
wiped

The Issue / Fix

vueMeta computed value returns undefined when theme is false.

if (this.$vuetify.theme === false) return

Returning an empty object rather than undefined fixes this.

@zerosym zerosym changed the title Nuxt -- theme: false wipes html head elements [Bug Report] Nuxt -- theme: false wipes html head elements Aug 25, 2018
@KaelWD
Copy link
Member

KaelWD commented Aug 26, 2018

You should probably report this to vue-meta too.

@KaelWD KaelWD added T: bug Functionality that does not work as intended/expected upstream Problem with a third party library that we may have to work around labels Aug 26, 2018
@alfredriesen
Copy link

vuetify schould return an empty Object instead of simply return:
if (this.$vuetify.theme === false) return {}
and not
if (this.$vuetify.theme === false) return
Then it schould work.

@KaelWD KaelWD self-assigned this Aug 28, 2018
@KaelWD KaelWD added this to the v1.1.x milestone Aug 28, 2018
@KaelWD KaelWD closed this as completed in 190274f Aug 28, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Aug 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected upstream Problem with a third party library that we may have to work around
Projects
None yet
Development

No branches or pull requests

3 participants