Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expand-transition): use a proper FLIP animation w/ offsetHeight #5709

Merged
merged 1 commit into from
Nov 23, 2018

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Nov 22, 2018

Motivation and Context

fixes #5607
also fixes an unreported bug caused by the use of scrollHeight, remove the inline style to see it

Markup:

<template>
  <v-app>
    <v-container>
      <v-img
        :aspect-ratio="16/9"
        max-width="600"
        src="https://cdn.vuetifyjs.com/images/cards/kitchen.png"
      >
        <v-expand-transition>
          <div
            v-if="show"
            class="d-flex transition-fast-in-fast-out orange darken-2 v-card--reveal display-3 white--text"
            style="height: 100%"
          >
            $14.99
          </div>
        </v-expand-transition>
      </v-img>
      <v-switch v-model="show"></v-switch>
    </v-container>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
      show: false
    })
  }
</script>

<style>
  .v-card--reveal {
    align-items: center;
    bottom: 0;
    justify-content: center;
    opacity: .5;
    position: absolute;
    width: 100%;
  }
</style>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

@vercel
Copy link

vercel bot commented Nov 22, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #5709 into master will decrease coverage by 0.03%.
The diff coverage is 53.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5709      +/-   ##
==========================================
- Coverage   88.99%   88.96%   -0.04%     
==========================================
  Files         262      262              
  Lines        5909     5920      +11     
  Branches     1467     1467              
==========================================
+ Hits         5259     5267       +8     
- Misses        531      534       +3     
  Partials      119      119
Impacted Files Coverage Δ
...fy/src/components/transitions/expand-transition.js 60% <53.33%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc5aaf...4f49efc. Read the comment docs.

@johnleider johnleider merged commit cb605ac into master Nov 23, 2018
@johnleider johnleider deleted the fix/5607-expand-transition-height branch November 23, 2018 02:03
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Regression in expand transition
2 participants