Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(selection-controls): use ripple even when disabled #5710

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #5653

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-content>
      <v-container>
        <v-switch v-model="active" :disabled="!enable" @change="activeChanged()" />
        <v-checkbox v-model="active" :disabled="!enable" @change="activeChanged()" />
      </v-container>
    </v-content>
  </v-app>
</template>

<script>
export default {
  methods: {
    activeChanged() {
      this.enable = false;
      setTimeout(() => (this.enable = true), 500);
    }
  },
  data: () => ({
    active: true,
    enable: true
  })
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Nov 22, 2018
@vercel
Copy link

vercel bot commented Nov 22, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #5710 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5710      +/-   ##
==========================================
+ Coverage   88.99%   89.01%   +0.01%     
==========================================
  Files         262      262              
  Lines        5909     5909              
  Branches     1467     1467              
==========================================
+ Hits         5259     5260       +1     
+ Misses        531      530       -1     
  Partials      119      119
Impacted Files Coverage Δ
packages/vuetify/src/components/VSwitch/VSwitch.js 88.23% <ø> (ø) ⬆️
...kages/vuetify/src/components/VRadioGroup/VRadio.js 100% <ø> (ø) ⬆️
...ages/vuetify/src/components/VCheckbox/VCheckbox.js 100% <ø> (ø) ⬆️
...fy/src/components/transitions/expand-transition.js 57.14% <0%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebc5aaf...fd88e52. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk merged commit 2150554 into master Nov 22, 2018
@jacekkarczmarczyk jacekkarczmarczyk deleted the fix/#5653-selection-controls-ripple branch November 22, 2018 17:07
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] v-switch jumps when changing disabled property
2 participants