Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes disabled styling for v-btn when a color prop is passed in #5734

Merged
merged 1 commit into from
Nov 26, 2018

Conversation

rkomiyama
Copy link
Contributor

Description

A check is added to see if the disabled prop has a true value. If so, then the render function will not call setBackgroundColor.

Motivation and Context

See issue here: #5720

How Has This Been Tested?

None.

Markup:

<template>
  <v-app>
    <v-content>
      <v-container grid-list-xl>
        <v-btn icon>
          <v-icon>print</v-icon>
        </v-btn>
        <v-btn icon color="primary">
          <v-icon>print</v-icon>
        </v-btn>
        <v-btn icon disabled>
          <v-icon>print</v-icon>
        </v-btn>
        <v-btn icon disabled color="primary">
          <v-icon>print</v-icon>
        </v-btn>
        <v-btn disabled color="primary">
          <v-icon>print</v-icon>
        </v-btn>
        <v-btn color="primary">
          <v-icon>print</v-icon>
        </v-btn>
      </v-container>
    </v-content>
  </v-app>
</template>

<script>
  export default {
    data: () => ({
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Nov 26, 2018

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Nov 26, 2018

Codecov Report

Merging #5734 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5734   +/-   ##
=======================================
  Coverage   89.02%   89.02%           
=======================================
  Files         262      262           
  Lines        5921     5921           
  Branches     1467     1467           
=======================================
  Hits         5271     5271           
  Misses        533      533           
  Partials      117      117
Impacted Files Coverage Δ
packages/vuetify/src/components/VBtn/VBtn.ts 82.92% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f32ef98...7c5a984. Read the comment docs.

@johnleider johnleider merged commit 069558a into vuetifyjs:master Nov 26, 2018
@rkomiyama rkomiyama deleted the fix/disabled-button-color branch March 13, 2019 19:41
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants