Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] VTab to and VTabItem combination crashing browser tab #5762

Closed
harlan-zw opened this issue Nov 29, 2018 · 2 comments
Closed

[Bug Report] VTab to and VTabItem combination crashing browser tab #5762

harlan-zw opened this issue Nov 29, 2018 · 2 comments
Assignees
Labels
P: critical The issue is of critical importance T: bug Functionality that does not work as intended/expected
Milestone

Comments

@harlan-zw
Copy link

Versions and Environment

Vuetify: 1.3.11
Vue: 2.5.17
Browsers: Chrome 70.0.3498.0, Safari, Mozilla Firefox
OS: Mac OS 10.13.4

Steps to reproduce

The exact point of failure is having v-tabs and a v-tab-item and then adding a to attribute to one of the v-tabs

<v-tabs>
  <v-tab to="/test">tab1</v-tab>
  <v-tab>tab2</v-tab>
  <v-tab>tab3</v-tab>

  <v-tab-item></v-tab-item>
</v-tabs>

Expected Behavior

The browser should not crash. I'd like to be able to use both a to and the v-tab-item so that users can visit tabs via direct link and use the tabs as usual

Actual Behavior

The tab freezes and becomes unresponsive.

Reproduction Link

https://codepen.io/anon/pen/QJJLNg

Other comments

There may be a better way of doing my use case, but the fact it's crashing the browser isn't good.

@johnleider
Copy link
Member

Workaround is to explicitly bind the value of v-tab-item: https://codepen.io/johnjleider/pen/VVVZVe

@johnleider johnleider self-assigned this Nov 29, 2018
@johnleider johnleider added T: bug Functionality that does not work as intended/expected P: critical The issue is of critical importance labels Nov 29, 2018
@johnleider johnleider added this to the v1.3.x milestone Nov 29, 2018
@johnleider johnleider modified the milestones: v1.3.x, v2.x Jan 2, 2019
@johnleider johnleider mentioned this issue Feb 27, 2019
8 tasks
@johnleider johnleider modified the milestones: v2.x.x, v2.0.0 Feb 27, 2019
@johnleider
Copy link
Member

Fixed in f22d754

@lock lock bot locked as resolved and limited conversation to collaborators Mar 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P: critical The issue is of critical importance T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

No branches or pull requests

2 participants