Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VSparkline): add fill property #6132

Merged
merged 8 commits into from Jan 19, 2019
Merged

feat(VSparkline): add fill property #6132

merged 8 commits into from Jan 19, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Jan 13, 2019

Description

#6022

Motivation and Context

#6022

How Has This Been Tested?

#6022

Markup:

#6022

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@dsseng dsseng added the T: feature A new feature label Jan 13, 2019
@dsseng dsseng added this to the v1.5.0 milestone Jan 13, 2019
@vercel
Copy link

vercel bot commented Jan 13, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Jan 13, 2019

Codecov Report

Merging #6132 into dev will decrease coverage by 0.14%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             dev    #6132      +/-   ##
=========================================
- Coverage   82.1%   81.95%   -0.15%     
=========================================
  Files        290      290              
  Lines       6961     6973      +12     
  Branches    1712     1717       +5     
=========================================
  Hits        5715     5715              
- Misses      1126     1138      +12     
  Partials     120      120
Impacted Files Coverage Δ
...es/vuetify/src/components/VSparkline/VSparkline.ts 5.05% <0%> (-0.51%) ⬇️
.../vuetify/src/components/VSparkline/helpers/path.ts 5.55% <0%> (-7.78%) ⬇️
...fy/src/components/transitions/expand-transition.js 76% <0%> (+4%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c912266...7876a5a. Read the comment docs.

@johnleider johnleider merged commit 54c3f83 into dev Jan 19, 2019
@johnleider johnleider deleted the feat/v-sparkline-fill branch January 19, 2019 02:12
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants