-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VSpeedDial): fixed transition animation #6373
Conversation
This pull request is automatically deployed with Now. |
Codecov Report
@@ Coverage Diff @@
## master #6373 +/- ##
=========================================
+ Coverage 85.59% 85.6% +<.01%
=========================================
Files 298 298
Lines 7165 7169 +4
Branches 1781 1782 +1
=========================================
+ Hits 6133 6137 +4
Misses 942 942
Partials 90 90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but fix issue @jacekkarczmarczyk reviewed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
This comment has been minimized.
This comment has been minimized.
@kuromoka don't worry, build failed because of our internal problems, I'll restart it |
I will add unit tests because of ci fail |
added unit test cf57183 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@kuromoka thanks! |
Description
VSpeedDial
transition animation only works until 7 buttons. Fixed that to work more than 7 buttonsMotivation and Context
fixes #5735
How Has This Been Tested?
visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).