Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VSpeedDial): fixed transition animation #6373

Merged
merged 6 commits into from
Feb 17, 2019

Conversation

kuromoka
Copy link
Contributor

@kuromoka kuromoka commented Feb 5, 2019

Description

VSpeedDial transition animation only works until 7 buttons. Fixed that to work more than 7 buttons

Motivation and Context

fixes #5735

How Has This Been Tested?

visually

Markup:

<template>
  <v-app>
    <v-card id="create">
      <v-speed-dial
        v-model="fab"
        top
        left
        direction="right"
        transition="slide-x-transition"
      >
        <v-btn
          slot="activator"
          v-model="fab"
          color="blue darken-2"
          dark
          fab
        >
          <v-icon>account_circle</v-icon>
          <v-icon>close</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="green"
        >
          <v-icon>edit</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="indigo"
        >
          <v-icon>add</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="red"
        >
          <v-icon>delete</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="red"
        >
          <v-icon>delete</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="red"
        >
          <v-icon>delete</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="red"
        >
          <v-icon>delete</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="red"
        >
          <v-icon>delete</v-icon>
        </v-btn>
        <v-btn
          fab
          dark
          small
          color="red"
        >
          <v-icon>delete</v-icon>
        </v-btn>
      </v-speed-dial>
    </v-card>
  </v-app>
</template>

<style>
  #create .v-speed-dial {
    position: absolute;
  }

  #create .v-btn--floating {
    position: relative;
  }
</style>

<script>
export default {
  data: () => ({
    fab: false
  })
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel
Copy link

vercel bot commented Feb 5, 2019

This pull request is automatically deployed with Now.
To access deployments, click Details below or on the icon next to each push.

@codecov
Copy link

codecov bot commented Feb 5, 2019

Codecov Report

Merging #6373 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6373      +/-   ##
=========================================
+ Coverage   85.59%   85.6%   +<.01%     
=========================================
  Files         298     298              
  Lines        7165    7169       +4     
  Branches     1781    1782       +1     
=========================================
+ Hits         6133    6137       +4     
  Misses        942     942              
  Partials       90      90
Impacted Files Coverage Δ
...es/vuetify/src/components/VSpeedDial/VSpeedDial.js 96.15% <100%> (+0.69%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 797808e...b10e725. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk added the T: bug Functionality that does not work as intended/expected label Feb 9, 2019
dsseng
dsseng previously approved these changes Feb 10, 2019
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but fix issue @jacekkarczmarczyk reviewed

@vercel vercel bot temporarily deployed to staging February 10, 2019 14:48 Inactive
@vercel vercel bot temporarily deployed to staging February 10, 2019 14:51 Inactive
dsseng
dsseng previously approved these changes Feb 10, 2019
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@TravisBuddy

This comment has been minimized.

@dsseng
Copy link
Contributor

dsseng commented Feb 10, 2019

@kuromoka don't worry, build failed because of our internal problems, I'll restart it

@vercel vercel bot temporarily deployed to staging February 10, 2019 14:59 Inactive
@kuromoka
Copy link
Contributor Author

I will add unit tests because of ci fail

@kuromoka
Copy link
Contributor Author

added unit test cf57183
I can't apply transition-delay style via unit test maybe because of vuejs/vue-test-utils#839 (comment)
let me know if problems

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsseng
Copy link
Contributor

dsseng commented Feb 17, 2019

@kuromoka thanks!

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Speed-dial animation only works for 7 buttons
4 participants