fix(ripple): ensure _ripple data is not undefined #6476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of assuming
element._ripple
won't be undefined/null (which it could be), verify that this is the case.Motivation and Context
Deleting a
v-btn
on click results in a console error "Cannot set property 'touched' of undefined at ripple.ts:148". This occurs when the ripple directive's unbind() function is called before rippleHide()'s setTimeout finishes.Steps to reproduce (codepen):
How Has This Been Tested?
visually (added the undefined guard manually to a vuetify build)
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).