Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue width get's ignored with scrollable dialogs #6480

Merged
merged 3 commits into from
Feb 12, 2019
Merged

Fix issue width get's ignored with scrollable dialogs #6480

merged 3 commits into from
Feb 12, 2019

Conversation

06b
Copy link
Contributor

@06b 06b commented Feb 12, 2019

Description

When flex: 1 1 0px get's applied to a scrollable dialog it takes up the full width, so change it so it only gets applied to the form that's nested within a scrollable dialog

Motivation and Context

Fixes #6479

How Has This Been Tested?

visually

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@vercel vercel bot temporarily deployed to staging February 12, 2019 23:34 Inactive
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.

@MajesticPotatoe MajesticPotatoe merged commit 592e3f4 into vuetifyjs:master Feb 12, 2019
@@ -84,6 +84,3 @@
> .v-card__text
overflow-y: auto
backface-visibility: hidden

&--scrollable > form
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe by removing this that it will re-introduce #3713 based off of this f90c8b9

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] V-Dialog > Width is ignored when using scrollable
3 participants