Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] text-truncate cuts off bottom part of title #6488

Closed
WIStudent opened this issue Feb 13, 2019 · 2 comments
Closed

[Bug Report] text-truncate cuts off bottom part of title #6488

WIStudent opened this issue Feb 13, 2019 · 2 comments

Comments

@WIStudent
Copy link

Versions and Environment

Vuetify: 1.5.1
Vue: 2.6.6
Browsers: Firefox 65.0
OS: Windows 10

Steps to reproduce

Create a div with classes "title" and "text-truncate"

<div class=title text-truncate">
gggyyy
</div>

Expected Behavior

Bottom of text should not be cut off:

Actual Behavior

Bottom of text is being cut off
grafik

Reproduction Link

https://codepen.io/wistudent/pen/xMJPQq

@blalan05
Copy link
Member

Simple fix, add a little padding: class="py-1". Text-truncate class only adds: overflow: hidden; text-overflow: ellipsis;

@06b
Copy link
Contributor

06b commented Feb 13, 2019

However due to .title having a line-height:1 !important; when the .text-truncate is added the overflow:hidden; will cause the issue of cutting off descenders on letters.

Changing the line-height to 1.1 would fix the issue in this case or it could be switched to normal which is the default line-height & would then be up to the user agent to use a "reasonable" value based on the font of the element according to the spec at least.

@dsseng dsseng closed this as completed in 8161cc0 Feb 13, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Feb 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants