-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes unnecessary outline for circle pagination buttons. #6513
Conversation
@iliyaZelenko please use the PR template in description, don't forget to include the Playground.vue for testing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@iliyaZelenko please use |
Codecov Report
@@ Coverage Diff @@
## master #6513 +/- ##
==========================================
- Coverage 85.59% 85.59% -0.01%
==========================================
Files 298 298
Lines 7165 7162 -3
Branches 1781 1781
==========================================
- Hits 6133 6130 -3
Misses 942 942
Partials 90 90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jacekkarczmarczyk said that there won't be any indication of active button when navigating with keyboard, reverting. @iliyaZelenko sorry
@jacekkarczmarczyk @sh7dm In this case, we could use the pseudo-class |
This will remove the unnecessary border:
For rectangular buttons, this does not interfere, but I think it is not necessary for circle ones.