Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unnecessary outline for circle pagination buttons. #6513

Merged
merged 3 commits into from
Feb 17, 2019

Conversation

iliyaZelenko
Copy link
Contributor

This will remove the unnecessary border:

For rectangular buttons, this does not interfere, but I think it is not necessary for circle ones.

@vercel vercel bot temporarily deployed to staging February 15, 2019 23:01 Inactive
@iliyaZelenko iliyaZelenko changed the title Update _pagination.styl Removes unnecessary outline for circle pagination buttons. Feb 15, 2019
@iliyaZelenko iliyaZelenko marked this pull request as ready for review February 15, 2019 23:05
@jacekkarczmarczyk
Copy link
Member

@iliyaZelenko please use the PR template in description, don't forget to include the Playground.vue for testing
image

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dsseng
Copy link
Contributor

dsseng commented Feb 17, 2019

@iliyaZelenko please use commitizen for good commit names

@codecov
Copy link

codecov bot commented Feb 17, 2019

Codecov Report

Merging #6513 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6513      +/-   ##
==========================================
- Coverage   85.59%   85.59%   -0.01%     
==========================================
  Files         298      298              
  Lines        7165     7162       -3     
  Branches     1781     1781              
==========================================
- Hits         6133     6130       -3     
  Misses        942      942              
  Partials       90       90
Impacted Files Coverage Δ
...ages/vuetify/src/components/VCarousel/VCarousel.ts 91.66% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be34e49...3eae588. Read the comment docs.

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacekkarczmarczyk said that there won't be any indication of active button when navigating with keyboard, reverting. @iliyaZelenko sorry

@iliyaZelenko
Copy link
Contributor Author

@jacekkarczmarczyk @sh7dm In this case, we could use the pseudo-class :focus. We can remove the outline, but for the focus to make a beautiful round border.

@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants