-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(VCarousel): transition direction when outside button click #6515
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6515 +/- ##
==========================================
+ Coverage 85.59% 85.59% +<.01%
==========================================
Files 298 298
Lines 7162 7165 +3
Branches 1781 1781
==========================================
+ Hits 6130 6133 +3
Misses 942 942
Partials 90 90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update tests to reflect this change and maintain coverage.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
@kuromoka thanks |
Description
Fixed transition direction when clicked outside buttons of
VCarousel
that changing index.Motivation and Context
fixes #6366
How Has This Been Tested?
visually
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).