Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ripple): allow getComputedStyle to return null #6639

Merged
merged 1 commit into from
Feb 28, 2019
Merged

fix(ripple): allow getComputedStyle to return null #6639

merged 1 commit into from
Feb 28, 2019

Conversation

neelance
Copy link
Contributor

The function window.getComputedStyle was returning null under certain conditions on Firefox before version 62, see https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle#Browser_compatibility.

Motivation and Context

JS Error on Firefox.

How Has This Been Tested?

Bug only happens on old Firefox versions. Is this something you want to explicitly test?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

The function window.getComputedStyle was returning null under certain conditions on Firefox before version 62, see https://developer.mozilla.org/en-US/docs/Web/API/Window/getComputedStyle#Browser_compatibility.
@codecov
Copy link

codecov bot commented Feb 28, 2019

Codecov Report

Merging #6639 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6639      +/-   ##
==========================================
+ Coverage   85.68%   85.68%   +<.01%     
==========================================
  Files         298      298              
  Lines        7174     7175       +1     
  Branches     1784     1784              
==========================================
+ Hits         6147     6148       +1     
  Misses        936      936              
  Partials       91       91
Impacted Files Coverage Δ
packages/vuetify/src/directives/ripple.ts 75.78% <100%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f8c235...4580374. Read the comment docs.

@johnleider johnleider merged commit 0bf395c into vuetifyjs:master Feb 28, 2019
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants