Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VToolbar/VAppBar): update to md2 spec #6701

Merged
merged 102 commits into from
Mar 11, 2019
Merged

feat(VToolbar/VAppBar): update to md2 spec #6701

merged 102 commits into from
Mar 11, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Mar 8, 2019 •
edited

Description

Update toolbar to match md2 spec

Motivation and Context

fixes #3373
fixes #3938
fixes #3985
fixes #4985
fixes #5369

How Has This Been Tested?

jest

Markup:

Use Kitchen or Docs

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

johnleider and others added 30 commits March 7, 2019 10:29
@johnleider
refactor(VToolbar): simplify usage, move out app-bar related features
dd1af55
@johnleider
feat(VAppBar): create new component
2b82fe8
@johnleider
chore(VToolbar/VAppBar): add backwards compat and deprecations
dedfca5
@johnleider
chore(VToolbar): add more deprecations
80feb4f
@johnleider
style(VToolbar): fix typings
c01ddc9
@johnleider
chore: finish unit tests, type cleanup
c16a6db
@johnleider
test(VAppBar): expand coverage
340f3b3
@johnleider
feat(VAppBar): add **shrink-on-scroll** prop
e101c8a 
converts a prominent toolbar to a dense/short toolbar on scroll
@johnleider
refactor(VAppBar): improve scroll-target functionality
afcf4ea
@johnleider
chore: remove component, improve interaction of buttons in toolbar
deefb33
@johnleider
fix(VToolbar): switch psuedo selector for btn icons
153a38f
@johnleider
docs(VAppBar/Toolbar): add documentation pages for app-bar
c057807
@johnleider
fix(VToolbar): use correct comparison for deprecation
e6bede6
@johnleider
refactor(VToolbar): revert psuedo selector, better scope margin styles
ac34f7c
@johnleider
Merge branch 'next' into feat/md2-toolbar
128851e
@johnleider
test: fix tests
1073670
@johnleider
feat(VToolbar/VAppBar): add collapse support
fe8d8ed
@johnleider
refactor(VToolbar): improve collapse behavior
ec48929
@johnleider
feat(VToolbar): add img support
3898551
@johnleider
feat(VAppBar): add **fade-img-on-scroll** prop
b5425a6
@dsseng
docs(VAppBar): add docs example for image
0ebc8b8
@dsseng
docs(VAppBar): add imgProps to example
63a0330
@dsseng
docs(VAppBar): add an example for fade-img-on-scroll property
e5edab7
@dsseng
style(docs): fix code style
3f8a800
@johnleider
refactor: improve scrolling height calculations, improve image support
e08bbdc
@nekosaur
docs(VAppBar): updated texts
f8b87ac
@dsseng
test(VAppBar): improve coverage
f6e1bf1
@johnleider
feat(VAppBar): match scroll with shrinking bar
881d75d
@johnleider
fix(VAppBar): only fade img when using the prop
85b51cf
@johnleider
fix(VAppBar): only shrink when prop provided
1178d93
@vercel vercel bot temporarily deployed to staging March 11, 2019 03:28 Inactive
@johnleider
fix(VAppBar): hide shadow when scroll-off-screen and hide-on-scroll
1ddb87a 
when used with extended should hide shadow once entire bar is transformed
dsseng
dsseng suggested changes Mar 11, 2019
View reviewed changes
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, but need some fixes

@vercel vercel bot temporarily deployed to staging March 11, 2019 16:03 Inactive
@vercel vercel bot temporarily deployed to staging March 11, 2019 16:07 Inactive
@johnleider johnleider merged commit fc8c2ed into next Mar 11, 2019
@johnleider johnleider deleted the feat/md2-toolbar branch March 11, 2019 16:16
@johnleider johnleider mentioned this pull request Mar 11, 2019
Closed
88 tasks
@lock
Copy link

lock bot commented Apr 14, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. Please direct any non-bug questions to our Discord

@lock lock bot locked as resolved and limited conversation to collaborators Apr 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nekosaur nekosaur nekosaur left review comments

@jacekkarczmarczyk jacekkarczmarczyk jacekkarczmarczyk left review comments

@dsseng dsseng dsseng requested changes

Assignees

@johnleider johnleider

@dsseng dsseng

Labels
md2 The issue pertains to Material Spec 2 T: bug Functionality that does not work as intended/expected T: enhancement Functionality that enhances existing features
Projects
None yet
Milestone
v2.0.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@johnleider @nekosaur @jacekkarczmarczyk @dsseng @KaelWD