Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VProgressLinear): update to md2 #7057

Merged
merged 42 commits into from
Apr 26, 2019
Merged

feat(VProgressLinear): update to md2 #7057

merged 42 commits into from
Apr 26, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Apr 23, 2019

Description

Update v-progress-linear component to match md2 specification

resolves #5147

Motivation and Context

  • Added new props

    • v-model - allow user to click to define value
    • stream - loading animation for use with buffer-value
    • striped - adds a striped background to the value portion of the component
  • Added new mixins

    • themeable
    • positionable
    • proxyable

Breaking

  • Explicit margin has been removed

How Has This Been Tested?

jest

Markup:

<template>
  <div class="ma-5 pa-5">
    <h3>Baseline</h3>
    <v-progress-linear></v-progress-linear>
    <br>
    <h3>Custom color</h3>
    <v-progress-linear
      color="purple"
      value="10"
    ></v-progress-linear>
    <br>
    <h3>Custom height</h3>
    <v-progress-linear
      color="cyan"
      value="30"
      height="7"
    ></v-progress-linear>
    <br>
    <h3>Indeterminate</h3>
    <v-progress-linear
      color="pink"
      indeterminate
    ></v-progress-linear>
    <br>
    <h3>Stream buffer</h3>
    <v-progress-linear
      color="indigo darken-2"
      buffer-value="0"
      stream
    ></v-progress-linear>
    <br>
    <h3>Stream value</h3>
    <v-progress-linear
      color="amber"
      value="30"
      buffer-value="0"
      stream
    ></v-progress-linear>
    <br>
    <h3>Stream buffer & value</h3>
    <v-progress-linear
      color="green"
      value="10"
      buffer-value="40"
      stream
    ></v-progress-linear>
    <br>
    <h3>Indeterminate query</h3>
    <v-progress-linear
      color="teal"
      indeterminate
      query
    ></v-progress-linear>
    <br>
    <h3>Rounded</h3>
    <v-progress-linear
      color="primary"
      rounded
      height="10"
      value="33"
    ></v-progress-linear>
    <br>
    <h3>Striped</h3>
    <v-progress-linear
      color="orange"
      striped
      height="12"
      value="45"
    ></v-progress-linear>
  </div>
</template>

<script>
  export default {
    data: () => ({
      //
    })
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Apr 23, 2019
@johnleider johnleider added this to the v2.0.0 milestone Apr 23, 2019
@johnleider johnleider self-assigned this Apr 23, 2019
@codecov
Copy link

codecov bot commented Apr 24, 2019

Codecov Report

Merging #7057 into next will increase coverage by <.01%.
The diff coverage is 95.34%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7057      +/-   ##
==========================================
+ Coverage   85.83%   85.84%   +<.01%     
==========================================
  Files         329      329              
  Lines        8326     8352      +26     
  Branches     2101     2107       +6     
==========================================
+ Hits         7147     7170      +23     
- Misses       1091     1092       +1     
- Partials       88       90       +2
Impacted Files Coverage Δ
packages/vuetify/src/components/VCard/VCard.ts 100% <ø> (ø) ⬆️
packages/vuetify/src/mixins/loadable/index.ts 71.42% <ø> (ø) ⬆️
.../src/components/VProgressLinear/VProgressLinear.ts 96.29% <95.34%> (-3.71%) ⬇️
packages/vuetify/src/components/VAlert/VAlert.ts 94.52% <0%> (-0.65%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d10bd1...da89395. Read the comment docs.

@vercel vercel bot temporarily deployed to staging April 24, 2019 19:20 Inactive
@vercel vercel bot temporarily deployed to staging April 24, 2019 19:21 Inactive
@vercel vercel bot temporarily deployed to staging April 25, 2019 13:10 Inactive
@johnleider johnleider dismissed stale reviews from nekosaur and dsseng April 26, 2019 13:33

feedback addressed

@johnleider johnleider merged commit fa69676 into next Apr 26, 2019
@johnleider johnleider deleted the refactor/md2-progress branch April 26, 2019 13:34
@lock lock bot locked as resolved and limited conversation to collaborators May 26, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants