Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): add property to Vue object to avoid memory leak #7497

Merged
merged 4 commits into from
Jun 14, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Jun 13, 2019

Description

Workaround for memory leak caused by infinite global mixins being declared when in dev mode using HMR

Motivation and Context

Fix memory leak

How Has This Been Tested?

Making changes in dev mode, triggering HMR for the documentation

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

memory leak caused by infinite global mixins being declared when in dev mode using HMR
@johnleider johnleider added the T: enhancement Functionality that enhances existing features label Jun 13, 2019
@johnleider johnleider requested a review from a team June 13, 2019 17:23
@johnleider johnleider self-assigned this Jun 13, 2019
@TravisBuddy
Copy link

TravisBuddy commented Jun 13, 2019

Hey @johnleider,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: ff01a1e0-8e6c-11e9-8722-2b49c01fe0f5

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #7497 into next will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7497      +/-   ##
==========================================
- Coverage   87.19%   87.17%   -0.03%     
==========================================
  Files         326      326              
  Lines        8447     8449       +2     
  Branches     2116     2117       +1     
==========================================
  Hits         7365     7365              
- Misses        992      994       +2     
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/install.ts 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c2b7a...1cfc5d2. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 13, 2019

Codecov Report

Merging #7497 into next will decrease coverage by 0.03%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7497      +/-   ##
==========================================
- Coverage   87.19%   87.15%   -0.04%     
==========================================
  Files         326      326              
  Lines        8447     8449       +2     
  Branches     2116     2117       +1     
==========================================
- Hits         7365     7364       -1     
- Misses        992      995       +3     
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/install.ts 0% <0%> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 93.99% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52c2b7a...0c8234c. Read the comment docs.

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, long waited fix!

dsseng
dsseng previously requested changes Jun 13, 2019
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need tests

@dsseng dsseng changed the title chore(install): add property to Vue object to avoid memory leak fix(install): add property to Vue object to avoid memory leak Jun 13, 2019
@dsseng dsseng requested review from dsseng and a team June 13, 2019 18:29
@dsseng dsseng dismissed their stale review June 13, 2019 18:39

Too obvious to test

dsseng
dsseng previously approved these changes Jun 13, 2019
@dsseng dsseng requested a review from a team June 13, 2019 18:39
@vercel vercel bot temporarily deployed to staging June 14, 2019 06:17 Inactive
KaelWD
KaelWD previously approved these changes Jun 14, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jul 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: enhancement Functionality that enhances existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants