-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(install): add property to Vue object to avoid memory leak #7497
Conversation
memory leak caused by infinite global mixins being declared when in dev mode using HMR
Hey @johnleider, TravisBuddy Request Identifier: ff01a1e0-8e6c-11e9-8722-2b49c01fe0f5 |
Codecov Report
@@ Coverage Diff @@
## next #7497 +/- ##
==========================================
- Coverage 87.19% 87.17% -0.03%
==========================================
Files 326 326
Lines 8447 8449 +2
Branches 2116 2117 +1
==========================================
Hits 7365 7365
- Misses 992 994 +2
Partials 90 90
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #7497 +/- ##
==========================================
- Coverage 87.19% 87.15% -0.04%
==========================================
Files 326 326
Lines 8447 8449 +2
Branches 2116 2117 +1
==========================================
- Hits 7365 7364 -1
- Misses 992 995 +3
Partials 90 90
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, long waited fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need tests
Description
Workaround for memory leak caused by infinite global mixins being declared when in dev mode using HMR
Motivation and Context
Fix memory leak
How Has This Been Tested?
Making changes in dev mode, triggering HMR for the documentation
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).