Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtn): adjust large button sizes to be consistent #7536

Merged
merged 2 commits into from
Jun 16, 2019
Merged

Conversation

kevinmarrec
Copy link
Contributor

@kevinmarrec kevinmarrec commented Jun 16, 2019

Description

Change large and x-large button sizes from 54px & 70px to 44px & 56px

Motivation and Context

See #7535

How Has This Been Tested?

Visually

Markup:

<div id="app">
  <v-app>
    <v-container fluid justify-center align-center>
      <v-btn x-small color="primary" dark>x-small</v-btn>
      <v-btn small color="secondary" dark>small</v-btn>
      <v-btn color="primary" dark>default</v-btn>
      <v-btn large color="secondary" dark>large</v-btn>
      <v-btn x-large color="primary" dark>x-large</v-btn>
    </v-container>
  </v-app>
</div>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.

@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #7536 into next will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7536      +/-   ##
==========================================
- Coverage   87.11%   87.09%   -0.02%     
==========================================
  Files         325      325              
  Lines        8449     8449              
  Branches     2116     2116              
==========================================
- Hits         7360     7359       -1     
- Misses        999     1000       +1     
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/components/VSelect/VSelect.ts 93.99% <0%> (-0.43%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8fbd1e...549d8e3. Read the comment docs.

@kevinmarrec kevinmarrec requested a review from a team June 16, 2019 15:37
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for normal sizes 👍

@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.0.0 milestone Jun 16, 2019
@codecov
Copy link

codecov bot commented Jun 16, 2019

Codecov Report

Merging #7536 into next will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7536      +/-   ##
==========================================
+ Coverage   87.09%   87.11%   +0.01%     
==========================================
  Files         325      325              
  Lines        8449     8449              
  Branches     2116     2116              
==========================================
+ Hits         7359     7360       +1     
+ Misses       1000      999       -1     
  Partials       90       90
Impacted Files Coverage Δ
packages/vuetify/src/components/VSelect/VSelect.ts 94.42% <0%> (+0.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be78722...a08b7c7. Read the comment docs.

@johnleider johnleider merged commit 7e2e2a4 into next Jun 16, 2019
@johnleider johnleider deleted the fix/btn-sizes branch June 16, 2019 22:04
@lock lock bot locked as resolved and limited conversation to collaborators Jul 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants