Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(VBtnToggle): add group prop #7582

Merged
merged 2 commits into from
Sep 25, 2019
Merged

feat(VBtnToggle): add group prop #7582

merged 2 commits into from
Sep 25, 2019

Conversation

johnleider
Copy link
Member

@johnleider johnleider commented Jun 19, 2019 •
edited
Loading

Description

Motivation and Context

resolves #4325

How Has This Been Tested?

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@johnleider johnleider added this to the v2.x.x milestone Jun 19, 2019
@johnleider johnleider self-assigned this Jun 19, 2019
@johnleider johnleider mentioned this pull request Jun 19, 2019
Closed
@johnleider johnleider added S: on hold The issue is on hold until further notice T: feature A new feature labels Jun 26, 2019
@jacekkarczmarczyk jacekkarczmarczyk removed the S: on hold The issue is on hold until further notice label Jul 28, 2019
@johnleider johnleider changed the base branch from next to dev August 1, 2019 17:47
@johnleider johnleider added the C: VBtnToggle VBtnToggle label Aug 1, 2019
@nekosaur
Copy link
Member

Missing playground markup

@nekosaur nekosaur added the missing information The issue was not created with issue creator label Aug 10, 2019
@johnleider
Copy link
Member Author

Missing playground markup

You're about to be missing

@johnleider johnleider marked this pull request as ready for review September 25, 2019 00:33
@johnleider johnleider removed the missing information The issue was not created with issue creator label Sep 25, 2019
@johnleider johnleider merged commit 33f031a into dev Sep 25, 2019
@johnleider johnleider deleted the feat/#4325-btn-block-group branch September 25, 2019 00:34
MajesticPotatoe pushed a commit that referenced this pull request Sep 27, 2019
@johnleider @MajesticPotatoe
feat(VBtnToggle): add new variants (#7582)
c727a14 
* feat(VBtnToggle): add group prop

* feat(VBtnToggle): add new variants

resolves #4325
@lock lock bot locked as resolved and limited conversation to collaborators Oct 25, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@johnleider johnleider

Labels
C: VBtnToggle VBtnToggle T: feature A new feature
Projects
None yet
Milestone
v2.x.x
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@johnleider @nekosaur @jacekkarczmarczyk