Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(VTreeview): **color** prop #7617

Merged
merged 5 commits into from Jun 24, 2019
Merged

feat(VTreeview): **color** prop #7617

merged 5 commits into from Jun 24, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

@jacekkarczmarczyk jacekkarczmarczyk commented Jun 20, 2019

Motivation and Context

fixes #7613

How Has This Been Tested?

playground

Markup:

<template>
  <div class="ma-5 pa-5">
    <v-treeview v-model="selected" rounded :active="selected" :items="treeItems" color="primary" activatable selectable hoverable />
    <v-divider />
    <v-treeview :items="treeItems" shaped color="red" activatable hoverable open-on-click />
  </div>
</template>

<script>
  export default {
    data: () => ({
      selected: [],
      treeItems: [
          {
            id: 1,
            name: 'Applications:',
            children: [
              { id: 2, name: 'Calendar' },
              {
                id: 3,
                name: 'Chrome',
                children: [
                  { id: 4, name: 'Foo', disabled: true },
                  { id: 5, name: 'Bar' },
                  { id: 6, name: 'Baz' }
                ],
              },
              { id: 7, name: 'Webstorm' }
            ]
          },
          {
            id: 8,
            name: 'Also applications:',
            disabled: true,
            children: [
              { id: 9, name: 'Calendar' },
              { id: 357, name: 'Chrome' },
            ]
          },
        ]
    }),
  }
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@TravisBuddy
Copy link

TravisBuddy commented Jun 20, 2019

Hey @jacekkarczmarczyk,
Something went wrong with the build.

TravisCI finished with status errored, which means the build failed because of something unrelated to the tests, such as a problem with a dependency or the build process itself.

View build log

TravisBuddy Request Identifier: 12a717e0-9663-11e9-9418-53fb1d2732c3

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #7617 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7617      +/-   ##
==========================================
+ Coverage   86.93%   86.93%   +<.01%     
==========================================
  Files         326      326              
  Lines        8536     8537       +1     
  Branches     2153     2154       +1     
==========================================
+ Hits         7421     7422       +1     
  Misses       1025     1025              
  Partials       90       90
Impacted Files Coverage Δ
.../vuetify/src/components/VTreeview/VTreeviewNode.ts 98.68% <100%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdb48c...3075d20. Read the comment docs.

@codecov
Copy link

codecov bot commented Jun 21, 2019

Codecov Report

Merging #7617 into next will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7617      +/-   ##
==========================================
+ Coverage   86.93%   86.94%   +<.01%     
==========================================
  Files         326      326              
  Lines        8536     8538       +2     
  Branches     2153     2154       +1     
==========================================
+ Hits         7421     7423       +2     
  Misses       1025     1025              
  Partials       90       90
Impacted Files Coverage Δ
.../vuetify/src/components/VTreeview/VTreeviewNode.ts 98.7% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffdb48c...6ff83fc. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk marked this pull request as ready for review June 21, 2019 05:04
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Jun 21, 2019
@jacekkarczmarczyk jacekkarczmarczyk added the T: feature A new feature label Jun 21, 2019
@jacekkarczmarczyk jacekkarczmarczyk changed the title feat(VTreeview): color prop feat(VTreeview): **color** prop Jun 21, 2019
@jacekkarczmarczyk
Copy link
Member Author

jacekkarczmarczyk commented Jun 22, 2019

Should we have a separate prop for text/background (color) and checkbox (selectedColor) or should they be merged into 1 color prop? @vuetifyjs/core-team.

@MajesticPotatoe
Copy link
Member

I think 2 props may be better.

@dsseng dsseng self-requested a review June 22, 2019 16:24
.v-treeview-node--active
background: map-get($material, 'dividers')
.v-treeview-node__root.v-treeview-node--active
&:before
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge 9&10 into one line and use :: as a good CSS3 practice

@vercel vercel bot temporarily deployed to staging June 24, 2019 09:31 Inactive
@dsseng dsseng merged commit b60b094 into next Jun 24, 2019
@dsseng dsseng deleted the feat/#7613-treeview-color branch June 24, 2019 09:32
@lock lock bot locked as resolved and limited conversation to collaborators Jul 24, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants