New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VTreeview): **color** prop #7617
Conversation
Hey @jacekkarczmarczyk, TravisCI finished with status TravisBuddy Request Identifier: 12a717e0-9663-11e9-9418-53fb1d2732c3 |
Codecov Report
@@ Coverage Diff @@
## next #7617 +/- ##
==========================================
+ Coverage 86.93% 86.93% +<.01%
==========================================
Files 326 326
Lines 8536 8537 +1
Branches 2153 2154 +1
==========================================
+ Hits 7421 7422 +1
Misses 1025 1025
Partials 90 90
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## next #7617 +/- ##
==========================================
+ Coverage 86.93% 86.94% +<.01%
==========================================
Files 326 326
Lines 8536 8538 +2
Branches 2153 2154 +1
==========================================
+ Hits 7421 7423 +2
Misses 1025 1025
Partials 90 90
Continue to review full report at Codecov.
|
Should we have a separate prop for text/background ( |
I think 2 props may be better. |
.v-treeview-node--active | ||
background: map-get($material, 'dividers') | ||
.v-treeview-node__root.v-treeview-node--active | ||
&:before |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merge 9&10 into one line and use ::
as a good CSS3 practice
Motivation and Context
fixes #7613
How Has This Been Tested?
playground
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).