Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: hyphenate remaining event names #7917

Merged
merged 2 commits into from
Jul 22, 2019
Merged

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

unifying event names

How Has This Been Tested?

jest

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Jul 22, 2019
@codecov
Copy link

codecov bot commented Jul 22, 2019

Codecov Report

Merging #7917 into next will increase coverage by 0.01%.
The diff coverage is 92.3%.

Impacted file tree graph

@@            Coverage Diff             @@
##             next    #7917      +/-   ##
==========================================
+ Coverage   85.64%   85.65%   +0.01%     
==========================================
  Files         333      333              
  Lines        9090     9091       +1     
  Branches     2414     2414              
==========================================
+ Hits         7785     7787       +2     
+ Misses       1212     1211       -1     
  Partials       93       93
Impacted Files Coverage Δ
.../components/VBottomNavigation/VBottomNavigation.ts 90% <0%> (ø) ⬆️
packages/vuetify/src/mixins/returnable/index.ts 60% <100%> (ø) ⬆️
packages/vuetify/src/mixins/picker-button/index.ts 100% <100%> (ø) ⬆️
.../vuetify/src/components/VDatePicker/VDatePicker.ts 94.23% <100%> (ø) ⬆️
.../components/VNavigationDrawer/VNavigationDrawer.ts 89.62% <100%> (ø) ⬆️
...components/VDatePicker/mixins/date-picker-table.ts 95.58% <100%> (ø) ⬆️
...tify/src/components/VAutocomplete/VAutocomplete.ts 99.24% <100%> (ø) ⬆️
packages/vuetify/src/components/VSelect/VSelect.ts 94.13% <0%> (+0.36%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6805263...4230ed6. Read the comment docs.

@jacekkarczmarczyk jacekkarczmarczyk added framework Issues and Feature Requests that have needs framework-wide. semver: major Contains breaking API changes labels Jul 22, 2019
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just may want to document the following in release notes:
update:searchInput -> update:search-input
update:inputValue -> update:input-value
update:miniVariant -> update:mini-variant
update:pickerDate -> update:picker-date
update:selectingYear -> update:selecting-year
tableDate -> update:table-date
picker-button update events -> kebabcase
update:returnValue -> update:return-value

@jacekkarczmarczyk
Copy link
Member Author

Updated notes, not sure what you mean by colorable update events -> kebabcase

@jacekkarczmarczyk jacekkarczmarczyk merged commit 6fac25d into next Jul 22, 2019
@jacekkarczmarczyk jacekkarczmarczyk deleted the fix/hyphenate-events branch July 22, 2019 21:50
@MajesticPotatoe
Copy link
Member

I meant picker buttons xD

@lock lock bot locked as resolved and limited conversation to collaborators Aug 22, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
framework Issues and Feature Requests that have needs framework-wide. semver: major Contains breaking API changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants