-
-
Notifications
You must be signed in to change notification settings - Fork 6.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hyphenate remaining event names #7917
Conversation
Codecov Report
@@ Coverage Diff @@
## next #7917 +/- ##
==========================================
+ Coverage 85.64% 85.65% +0.01%
==========================================
Files 333 333
Lines 9090 9091 +1
Branches 2414 2414
==========================================
+ Hits 7785 7787 +2
+ Misses 1212 1211 -1
Partials 93 93
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just may want to document the following in release notes:
update:searchInput
-> update:search-input
update:inputValue
-> update:input-value
update:miniVariant
-> update:mini-variant
update:pickerDate
-> update:picker-date
update:selectingYear
-> update:selecting-year
tableDate
-> update:table-date
picker-button update events -> kebabcase
update:returnValue
-> update:return-value
Updated notes, not sure what you mean by |
I meant picker buttons xD |
Motivation and Context
unifying event names
How Has This Been Tested?
jest
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).