Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(styles): float classes breakpointed #7922

Merged
merged 5 commits into from
Jul 22, 2019
Merged

Conversation

jacekkarczmarczyk
Copy link
Member

BREAKING CHANGE

removes .left and .right classes in favour of .float-{breakpont}-{dir}

Motivation and Context

make float classes similiar to all other utility classes

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)

BREAKING CHANGE

removes .left and .right classes in favour of .float-{breakpont}-{dir}
johnleider
johnleider previously approved these changes Jul 22, 2019
@jacekkarczmarczyk
Copy link
Member Author

Release notes updated

@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.0.0 milestone Jul 22, 2019
@jacekkarczmarczyk jacekkarczmarczyk merged commit 26ad2e5 into next Jul 22, 2019
@jacekkarczmarczyk jacekkarczmarczyk deleted the feat/float-classes branch July 22, 2019 19:32
@lock lock bot locked as resolved and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants