Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] VAvatar inside small VChip is not sized properly #8129

Closed
Dylan-Chapman opened this issue Jul 28, 2019 · 7 comments
Closed

[Bug Report] VAvatar inside small VChip is not sized properly #8129

Dylan-Chapman opened this issue Jul 28, 2019 · 7 comments
Assignees
Labels
C: VChip VChip T: bug Functionality that does not work as intended/expected
Milestone

Comments

@Dylan-Chapman
Copy link

Environment

Vuetify Version: 2.0.2
Vue Version: 2.6.10
Browsers: Chrome 75.0.3770.142
OS: Windows 10

Steps to reproduce

Create a VChip component with the small prop and a child VAvatar

Expected Behavior

VAvatar has spacing between itself and the edge of the VChip just like it does when the small prop isn't set

Actual Behavior

VAvatar goes to the edge of the VChip

Reproduction Link

https://codepen.io/Dylan-Chapman/pen/QedyQg

Other comments

This also can't be fixed by setting the VAvatar's size prop because of !important style declarations.

@ghost ghost added the S: triage label Jul 28, 2019
@Dylan-Chapman
Copy link
Author

Don't know if it's worth making a separate issue over, but VAvatar is also over-sized when the VChip has both small and pill props set.

@jacekkarczmarczyk
Copy link
Member

You can add this other issue to the codepen

@Dylan-Chapman
Copy link
Author

The codepen has been updated to show both of these issues.

@diazemiliano-zz diazemiliano-zz added C: VChip VChip T: bug Functionality that does not work as intended/expected and removed S: triage labels Aug 2, 2019
@dsseng
Copy link
Contributor

dsseng commented Aug 2, 2019

The problem is present with any non-default sizes:
image
Codepen: https://codepen.io/sh7dm/pen/KOXdBe
Playground:

<template>
  <v-container>
    <v-layout justify-space-around wrap align-space-around>
      <v-flex>
        <v-chip x-small>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
        <v-chip x-small pill>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
      </v-flex>

      <v-flex>
        <v-chip small>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
        <v-chip small pill>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
      </v-flex>

      <v-flex>
        <v-chip>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
        <v-chip pill>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
      </v-flex>

      <v-flex>
        <v-chip large>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
        <v-chip large pill>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
      </v-flex>

      <v-flex>
        <v-chip x-large>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
        <v-chip x-large pill>
          <v-avatar color="blue">A</v-avatar>
          Text
        </v-chip>
      </v-flex>
    </v-layout>
  </v-container>
</template>

<script>
export default {
  data: () => ({
  })
}
</script>

@dsseng
Copy link
Contributor

dsseng commented Aug 2, 2019

also I noticed that avatar is positioned incorrectly

@bykka
Copy link

bykka commented Sep 2, 2019

@sh7dm for some cases helps property "left" for v-avatar.
<v-avatar left>...

@johnleider johnleider added this to To do in Vuetify 3 - Titan via automation Jul 1, 2021
@johnleider johnleider added this to the v3.0.0 milestone Jul 1, 2021
@johnleider johnleider self-assigned this Jul 1, 2021
@johnleider
Copy link
Member

resolved by #13192

If you have any questions, please reach out to us in our Discord community.

Vuetify 3 - Titan automation moved this from To do to Done Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VChip VChip T: bug Functionality that does not work as intended/expected
Projects
No open projects
Development

No branches or pull requests

6 participants