Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VBtn): correct font-size for different VBtn sizes #8385

Merged
merged 2 commits into from Aug 15, 2019
Merged

fix(VBtn): correct font-size for different VBtn sizes #8385

merged 2 commits into from Aug 15, 2019

Conversation

obennaci
Copy link
Contributor

@obennaci obennaci commented Aug 8, 2019

fix #8358

Description

Motivation and Context

How Has This Been Tested?

Playground

Markup:

<template>
  <v-container>
    <v-btn x-small>X-SMALL</v-btn>
    <v-btn small>SMALL</v-btn>
    <v-btn>DEFAULT</v-btn>
    <v-btn large>LARGE</v-btn>
    <v-btn x-large>X-LARGE</v-btn>
  </v-container>
</template>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk
Copy link
Member

This is current PR:
image

How about this sizes?

$btn-font-sizes: (
  'x-small': .625rem,
  'small': .75rem,
  'default': .875rem,
  'large': 1rem,
  'x-large': 1.125rem
) !default;

image

@obennaci
Copy link
Contributor Author

I've only replicated the small and large sizes from v1.5

Tried the suggested sizes and they seem better overall, let me know if I should update them.

@johnleider
Copy link
Member

Go ahead and make the suggested changes, looks good.

@vercel vercel bot temporarily deployed to staging August 13, 2019 13:03 Inactive
@johnleider johnleider merged commit c67b666 into vuetifyjs:master Aug 15, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VBtn size doesn't affect font-size
4 participants