Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VFileInput): bug in Safari where file is not added #8498

Merged
merged 2 commits into from Aug 15, 2019

Conversation

nekosaur
Copy link
Member

Description

Safari does not seem to emit an input event when selecting a file, even though
from what I can see the HTML spec says both an input and change event should
be emitted.

Motivation and Context

closes #7941

How Has This Been Tested?

playground

Markup:

<template>
  <v-container class="pa-0">
    <v-file-input label="File input" v-model="asd"></v-file-input>
    {{ asd }}
  </v-container>
</template>

<script>
export default {
  data: () => ({
    asd: null,
    mode: 'hex',
    color: '#ff00ff'
  }),
  watch: {
    asd (v) {
      console.log(v)
    }
  }
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

Safari does not seem to emit an input event when selecting a file, even though
from what I can see the HTML spec says both an input and change event should
be emitted.

closes #7941
johnleider
johnleider previously approved these changes Aug 15, 2019
@johnleider johnleider added this to the v2.0.x milestone Aug 15, 2019
@johnleider johnleider added C: VFileInput T: bug Functionality that does not work as intended/expected labels Aug 15, 2019
@johnleider johnleider merged commit 0b4a970 into master Aug 15, 2019
@johnleider johnleider deleted the fix/7941-file-input-safari branch August 15, 2019 18:23
@lock lock bot locked as resolved and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VFileInput T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] VFileInput does not work with Safari on MacOS or iOS
2 participants