fix(VInput): add role alert to success/error messages

[MajesticPotatoe]

Description

Adds role alert to v-messages__wrapper so that screenreader can read message/error/hint

Motivation and Context

Fixes #8431

How Has This Been Tested?

visually | chromevox

Markup:

<template>
  <v-container>
    <v-switch
      v-model="success"
      label="Success"
    />
    <v-switch
      v-model="error"
      label="Error"
    />
    <v-switch
      v-model="hint"
      label="Hint"
    />
    <v-input
      :error="error"
      :error-messages="error ? message : ''"
      :hint="message"
      :success="success"
      :success-messages="success ? message : ''"
      :persistent-hint="hint"
    >
      Input
    </v-input>
    <v-text-field
      label="Textfield"
      :error="error"
      :error-messages="error ? message : ''"
      :hint="message"
      :success="success"
      :success-messages="success ? message : ''"
      :persistent-hint="hint"
    ></v-text-field>
    <v-select
      label="Select"
      :error="error"
      :error-messages="error ? message : ''"
      :hint="message"
      :success="success"
      :success-messages="success ? message : ''"
      :persistent-hint="hint"
    ></v-select>
    <v-combobox
      label="Combobox"
      :error="error"
      :error-messages="error ? message : ''"
      :hint="message"
      :success="success"
      :success-messages="success ? message : ''"
      :persistent-hint="hint"
    ></v-combobox>
    <v-autocomplete
      label="Autocomplete"
      :error="error"
      :error-messages="error ? message : ''"
      :hint="message"
      :success="success"
      :success-messages="success ? message : ''"
      :persistent-hint="hint"
    ></v-autocomplete>
  </v-container>
</template>

<script>
  export default {
    data: () => ({
      message: 'Message Text',
      success: false,
      error: false,
      hint: false,
    }),
  }
</script>

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

• The PR title is no longer than 64 characters.
• The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
• My code follows the code style of this project.
• I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
• I've added new examples to the kitchen (applies to new features and breaking changes in core library)

[TravisBuddy]

Hey @MajesticPotatoe,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: eacb3780-e0c0-11e9-9589-952cf72143c3

[jacekkarczmarczyk]

VMessages is used to display hints as well - should they have role alert?

[MajesticPotatoe]

VMessages is used to display hints as well - should they have role alert?

Is there an alternative to alert for non-time sensitive info, or should we only limit this to success/error?

[jacekkarczmarczyk]

#8431 (comment)

still some changes need to be made.

[johnleider]

What's the status on this?

[MajesticPotatoe]

What's the status on this?

@johnleider gotta move this so that its conditional based on message usage.

resolved

[dsseng]

LGTM

[KaelWD]

Not a feature, can rebase to master

[dsseng]

LGTM

[dsseng]

LGTM