Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Simple Icons #8892

Closed
SumNeuron opened this issue Sep 7, 2019 · 7 comments
Closed

[Feature Request] Simple Icons #8892

SumNeuron opened this issue Sep 7, 2019 · 7 comments
Assignees
Labels
C: VIcon VIcon T: enhancement Functionality that enhances existing features
Milestone

Comments

@SumNeuron
Copy link

Problem to solve

Brand related icons

Proposed solution

Integrate https://simpleicons.org/ as supported icons ets

@ghost ghost added the S: triage label Sep 7, 2019
@dsseng
Copy link
Contributor

dsseng commented Sep 8, 2019

@SumNeuron I know Simple Icons. Sorry, we can't add them as a main icons option since they don't have smth like arrow back, options or file upload icons. So maybe just support for v-icon.

@dsseng dsseng added C: VIcon VIcon maybe Functionality that we are considering T: enhancement Functionality that enhances existing features and removed S: triage labels Sep 8, 2019
@SumNeuron
Copy link
Author

If I register it in icon fonts and it only works in v-icon as a supplementary icon set, I would be super happy. mdi-icons (Vuetify 2.0's default), is moving away from branded icons so for people wanting to link to dependencies (e.g. Rollup), list various products / blog interests, or skills (e.g. Adobe), would really benefit from having them easily accessible:

// vuetify.js plugin / nuxt.config.js
{
  //...
   icons: ['mdi', 'simpleicons', ...]
}
<v-icon>si-adobe-illustrator</v-icon>

@dsseng
Copy link
Contributor

dsseng commented Sep 8, 2019

okay, so we'll just add Simple Icons to v-icon. no Icons service support

@dsseng dsseng self-assigned this Sep 8, 2019
@Paulsky
Copy link

Paulsky commented Oct 3, 2019

I also would like to see SimpleIcons to be integrated. Mainly, because the brand icons in Material Design Icons are deprecated and they recommend SimpleIcons themselves: http://dev.materialdesignicons.com/roadmap/brand-icons

@johnleider
Copy link
Member

johnleider commented Dec 3, 2020

For version 3 we are redoing how v-icon handles all first party supported icon libraries as well as drastically improving third party support.

You can watch #12699 for updates on how v-icon will work in the future.

If you have any additional questions, please reach out to us in our Discord community.

@johnleider johnleider self-assigned this Dec 3, 2020
@johnleider johnleider added this to the v3.0.0 milestone Dec 3, 2020
@johnleider johnleider added V3: Phase 1 and removed maybe Functionality that we are considering V3: Phase 1 labels Dec 3, 2020
@Alexisgt01
Copy link

Alexisgt01 commented Oct 3, 2021

npm i simple-icons

// plugins/vuetify.js

import Vue from 'vue';
import Vuetify from 'vuetify';

Vue.use(Vuetify);

let vuetify = new Vuetify({
    ...
    icons: {
        iconfont: 'mdi',
    }
});

const simpleIcons = require('simple-icons');

for (const iconSlug in simpleIcons) {
    const icon = simpleIcons.Get(iconSlug);
    vuetify.framework.icons.values[`si-${icon.slug}`] = icon.path
}

export default vuetify;

<v-icon>$si-youtube</v-icon>

@patrickelectric

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VIcon VIcon T: enhancement Functionality that enhances existing features
Projects
None yet
Development

No branches or pull requests

6 participants