Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VCalendar): fixed day width in month view on Firefox #9092

Merged
merged 3 commits into from
Sep 26, 2019

Conversation

igadmile
Copy link
Contributor

Description

As per specification, flex child elements should have min-width:0 property (min-height for columns) set
to prevent element overflow. See https://bugzilla.mozilla.org/show_bug.cgi?id=1114904

Motivation and Context

fix #9058

How Has This Been Tested?

Visually

Markup:

<template>
  <v-sheet height="600" width="300">
    <v-calendar
      v-model="focus"
      color="primary"
      :events="events"
      :event-margin-bottom="3"
      :now="today"
      type="month"
    ></v-calendar>
  </v-sheet>
</template>

<script>
export default {
  data: () => ({
    today: "2019-01-08",
    focus: "2019-01-08",
    events: [
      {
        name: "Very looong",
        start: "2019-01-14 18:00",
        end: "2019-01-14 19:00",
        color: "#4285F4"
      }
    ]
  })
};
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

As per specification, flex child elements should have min-width:0 property (min-height for columns) set
to prevent element overflow. See https://bugzilla.mozilla.org/show_bug.cgi?id=1114904

fix vuetifyjs#9058
Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reference FF bug too

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dsseng dsseng merged commit 5ff3941 into vuetifyjs:master Sep 26, 2019
@dsseng
Copy link
Contributor

dsseng commented Sep 26, 2019

Thank you for your contribution and interest in improving Vuetify! Make sure to join us in the Discord community.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Calendar fixed-width day field in month view
2 participants