Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(vdatepicker): fix min date #9097

Merged
merged 2 commits into from
Oct 10, 2019

Conversation

YipingRuan
Copy link
Contributor

@YipingRuan YipingRuan commented Sep 25, 2019

fix #9039

Description

Fix min date compare logic (Inclusive)

Motivation and Context

#9039

How Has This Been Tested?

Visually and added unit test

Markup:

<template>
  <v-container>
    {{ min }}
    <v-date-picker :min="min"></v-date-picker>
  </v-container>
</template>

<script>
export default {
  data: () => ({
    min: '2019-09-28T15:55:56.441Z'
  })
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add a unit test corresponding to your changes

Copy link
Contributor

@dsseng dsseng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@johnleider johnleider merged commit 45c07c5 into vuetifyjs:master Oct 10, 2019
@YipingRuan YipingRuan deleted the Fix/#9039_Min_Date branch October 11, 2019 08:36
@lock lock bot locked as resolved and limited conversation to collaborators Nov 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] DatePicker possible dates do not include the minimum date
4 participants