Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug Report] [v-text-field] In dense mode, when it is not outlined, the fieldname disappears #9105

Closed
cafedo opened this issue Sep 26, 2019 · 8 comments · May be fixed by ajesse11x/ethereumbook#1 or ajesse11x/vuetify#2
Labels
C: VTextField VTextField T: bug Functionality that does not work as intended/expected
Milestone

Comments

@cafedo
Copy link

cafedo commented Sep 26, 2019

Environment

Vuetify Version: 2.1.0-beta.0
Vue Version: 2.6.10
Browsers: Edge 78.0.276.2
OS: Windows 10

Steps to reproduce

See codepen

Expected Behavior

When a text field is dense, not outlined and the user enters a text, I'll expect that the label goes in the top part of the control

Actual Behavior

When a text field is dense, not outlined and the user enters a text, the label disappear

Reproduction Link

https://codepen.io/cafedo/pen/OJLGLZG?&editable=true&editors=101

@ghost ghost added the S: triage label Sep 26, 2019
@DRoet
Copy link
Contributor

DRoet commented Sep 26, 2019

@melbahja friendly ping since u are the PR author for dense

@cafedo cafedo changed the title [Bug Report] [v-text-field] In dense mode, when it is not outlined, the fieldname disappear [Bug Report] [v-text-field] In dense mode, when it is not outlined, the fieldname disappears Sep 26, 2019
@melbahja
Copy link
Contributor

melbahja commented Sep 26, 2019

dense in md docs not clear, but if john want this i will open a new PR
https://codepen.io/dev0x0/pen/ExYJVKE

@melbahja
Copy link
Contributor

@MajesticPotatoe
Copy link
Member

MajesticPotatoe commented Sep 26, 2019

@melbahja we had discussed this in discord. I requested @cafedo to make this issue. Label should remain, as there is a spec for it to exist in a non-outline scenario, and users can choose to toggle it off using the single-line prop

@melbahja
Copy link
Contributor

I didn't see it in discord :), ok i will open a new PR to fix this

@MajesticPotatoe
Copy link
Member

MajesticPotatoe commented Sep 26, 2019

Not a problem, was in sponsor chat. Should be pretty easy fix. Dense text field with a label should be 52dp height.

@cafedo
Copy link
Author

cafedo commented Sep 26, 2019

Ok, thanks @MajesticPotatoe for the support and thanks @melbahja for the PR that you will develop.

@MajesticPotatoe MajesticPotatoe added C: VTextField VTextField T: bug Functionality that does not work as intended/expected Prerelease and removed S: triage labels Sep 26, 2019
@KaelWD
Copy link
Member

KaelWD commented Sep 26, 2019

#8810 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C: VTextField VTextField T: bug Functionality that does not work as intended/expected
Projects
None yet
5 participants