Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VDialog/VMenu/VTooltip): hide wrapper element when not attached #9163

Merged
merged 2 commits into from
Oct 1, 2019

Conversation

KaelWD
Copy link
Member

@KaelWD KaelWD commented Oct 1, 2019

Description

Adds display: none to the root element unless it's attached to itself (because then we'd be hiding the content too)

Motivation and Context

fixes #6951
The previous commit 97681ce only helps in an inline context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Co-Authored-By: Daan Roet <DRoet@users.noreply.github.com>
@johnleider johnleider added this to the v2.1.0 milestone Oct 1, 2019
@johnleider johnleider added C: VDialog VDialog C: VMenu VMenu C: VTooltip VTooltip T: bug Functionality that does not work as intended/expected labels Oct 1, 2019
@johnleider johnleider merged commit 5a100ac into dev Oct 1, 2019
@johnleider johnleider deleted the fix/6951-detachable-wrapper-visibility branch October 1, 2019 16:52
@lock lock bot locked as resolved and limited conversation to collaborators Oct 31, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VDialog VDialog C: VMenu VMenu C: VTooltip VTooltip T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants