Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add prop for disabling keyboard lookup in VSelect #9297

Merged
merged 1 commit into from Nov 30, 2019
Merged

feat: Add prop for disabling keyboard lookup in VSelect #9297

merged 1 commit into from Nov 30, 2019

Conversation

srdecny
Copy link
Contributor

@srdecny srdecny commented Oct 9, 2019

Currently, there's no way to disable keyboard lookup when using VSelect.

Add a new prop to disable the lookup.

Description

Motivation and Context

When the user is typing, the intermediate search result items are selected. This can break other things on the page. See #9271

How Has This Been Tested?

Visually.

Markup:

// Paste your FULL Playground.vue here

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

Currently, there's no way to disable keyboard lookup when using VSelect.
@johnleider johnleider added this to the v2.2.0 milestone Nov 30, 2019
@johnleider johnleider added the T: feature A new feature label Nov 30, 2019
@johnleider johnleider merged commit b0a7c30 into vuetifyjs:dev Nov 30, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Jan 1, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VSelect VSelect T: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants