Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VTreeview): stuttering animation of toggle icon when loading #9705

Merged
merged 2 commits into from Nov 20, 2019

Conversation

jacekkarczmarczyk
Copy link
Member

Motivation and Context

fixes #9475

How Has This Been Tested?

playground

Markup:

<template>
  <v-container>
    <div class="v-icon v-treeview-node__toggle mdi mdi-cached v-treeview-node__toggle--loading" />
    <div class="v-icon mdi mdi-cached v-treeview-node__toggle--loading" />

    <v-divider />

    <v-treeview :load-children="fetch" :items="items" open-on-click selectable />
  </v-container>
</template>

<script>
export default {
  data: () => ({
    items: [{ id: 1, name: 'All Breweries', children: [] }],
  }),

  methods: {
    async fetch () {
      await new Promise((resolve) => { setTimeout(() => resolve(), 5000) })
      this.items[0].children = [{ id: 2, name: 'Some Brewery', children: [] }]
    },
  },
}
</script>

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@jacekkarczmarczyk jacekkarczmarczyk added T: bug Functionality that does not work as intended/expected C: VTreeview VTreeview labels Nov 16, 2019
@jacekkarczmarczyk jacekkarczmarczyk added this to the v2.1.x milestone Nov 16, 2019
@jacekkarczmarczyk jacekkarczmarczyk self-assigned this Nov 16, 2019
@nekosaur nekosaur self-requested a review November 17, 2019 11:46
nekosaur
nekosaur previously approved these changes Nov 17, 2019
@johnleider johnleider merged commit b729afc into master Nov 20, 2019
@johnleider johnleider deleted the fix/#9475-treeview-icon-animation branch November 20, 2019 19:36
@lock lock bot locked as resolved and limited conversation to collaborators Dec 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
C: VTreeview VTreeview T: bug Functionality that does not work as intended/expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug Report] Stuttering loading animation in treeview
3 participants