Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: create more preset variables #9766

Merged
merged 64 commits into from Dec 3, 2019
Merged

feat: create more preset variables #9766

merged 64 commits into from Dec 3, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Nov 22, 2019 •
edited

Description

Create more preset variables

Motivation and Context

Easier customization of framework for end user.

TODO list:

  • VApp
  • VAppBar
  • VAlert
  • VAutocomplete
  • VAvatar
  • VBadge
  • VBanner
  • VBottomNavigation
  • VBottomSheet
  • VBreadcrumbs
  • VBtn
  • VBtnToggle
  • VCalendar
  • VCard
  • VCarousel
  • VCheckbox
  • VChip
  • VChipGroup
  • VColorPicker
  • VContent
  • VCombobox
  • VCounter
  • VData
  • VDataIterator
  • VDataTable
  • VDatePicker
  • VDialog
  • VDivider
  • VExpansionPanel
  • VFileInput
  • VFooter
  • VForm
  • VGrid
  • VHover
  • VIcon
  • VImg
  • VInput
  • VItemGroup
  • VLabel
  • VLazy
  • VList
  • VMenu
  • VMessages
  • VNavigationDrawer
  • VOverflowBtn
  • VOverlay
  • VPagination
  • VSheet
  • VParallax
  • VPicker
  • VProgressCircular
  • VProgressLinear
  • VRadioGroup
  • VRangeSlider
  • VRating
  • VResponsive
  • VSelect
  • VSkeletonLoader
  • VSlider
  • VSlideGroup
  • VSnackbar
  • VSparkline
  • VSpeedDial
  • VStepper
  • VSubheader
  • VSwitch
  • VSystemBar
  • VTabs
  • VTextarea
  • VTextField
  • VTimeline
  • VTimePicker
  • VToolbar
  • VTooltip
  • VTreeview
  • VWindow

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist:

  • The PR title is no longer than 64 characters.
  • The PR is submitted to the correct branch (master for bug fixes and documentation updates, dev for new features and breaking changes).
  • My code follows the code style of this project.
  • I've added relevant changes to the documentation (applies to new features and breaking changes in core library)
  • I've added new examples to the kitchen (applies to new features and breaking changes in core library)

@dsseng dsseng self-assigned this Nov 22, 2019
@johnleider johnleider added this to the v2.2.0 milestone Nov 22, 2019
@johnleider johnleider added framework Issues and Feature Requests that have needs framework-wide. T: enhancement Functionality that enhances existing features T: feature A new feature labels Nov 22, 2019
MajesticPotatoe
MajesticPotatoe reviewed Nov 23, 2019
View reviewed changes
Copy link
Member

@MajesticPotatoe MajesticPotatoe left a comment •
edited by dsseng

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to note: the following need their _variable files changed from sass to scss for consistency with all the other variable files and for the var generator to pick up on them:

  • VChipGroup
  • VItemGroup
  • VWindow
  • VTooltip
  • VSwitch

johnleider and others added 27 commits December 2, 2019 10:15
@johnleider
Merge branch 'dev' into feat/preset-variables
f1fcf4e
@johnleider
chore: fix sass errors
69b382e
@johnleider
feat(VCard): add sass variables
218385f
@johnleider
feat(VChip): add sass variables
1b187b2
@johnleider
feat(VDialog): add sass variables
07fca4b
@johnleider
feat(VInput): add sass variables
b2b1b0a
@dsseng
feat(VTimePicker): add more Sass variables
521047d
@johnleider
refactor(VSwitch): clean up variables, fix broken ones
00da548
@johnleider
feat(VLabel): add sass variables
40f17fb
@dsseng
feat(VTextField): add more Sass variables
19fb657
@johnleider
refactor(VOverflowBtn): add sass variables and fix styles
107e13c
@johnleider
feat(VNavigationDrawer): add sass variables
b456ca0
@johnleider
feat(VPagination): add sass variables
9448f09
@johnleider
feat(VSkeletonLoader): add sass variables
b96d03a
@johnleider
feat(VStepper): add sass variables
0ad7525
@johnleider
feat(VTabs): add sass variables
a754504
@johnleider
feat(VList): add sass variables
50efc02
@johnleider
feat(VProgressLinear): add sass variables
46d2164
@johnleider
feat(VSnackbar): add sass variables
596b73a
@johnleider
refactor(VTextField): fix outlined active border styles
a9dbeba
@johnleider
feat(VTextarea): add sass variables
4390f1e
@jacekkarczmarczyk
refactor(VDatePicker): add sass variables
1dfa749
@dsseng
feat(VSelect): add Sass variables
d17ea2c
@johnleider
Merge branch 'dev' into feat/preset-variables
b4dc400
@johnleider
feat(VDataIterator): add sass variables
d79ebde
@johnleider
feat(VDataTable): add sass variables
1b29e8c
@johnleider
feat(VSlider): add sass variables
9ef4b25
@johnleider johnleider merged commit 2c901ba into dev Dec 3, 2019
@johnleider johnleider deleted the feat/preset-variables branch December 3, 2019 19:36
@lock lock bot locked as resolved and limited conversation to collaborators Jan 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacekkarczmarczyk jacekkarczmarczyk jacekkarczmarczyk left review comments

@MajesticPotatoe MajesticPotatoe MajesticPotatoe left review comments

@johnleider johnleider Awaiting requested review from johnleider

Assignees

@dsseng dsseng

Labels
framework Issues and Feature Requests that have needs framework-wide. T: enhancement Functionality that enhances existing features T: feature A new feature
Projects
None yet
Milestone
v2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dsseng @jacekkarczmarczyk @MajesticPotatoe @johnleider