New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(VPagination): add a11y support #9926
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except some translations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, otherwise LGTM.
I've moved this to the |
@johnleider I think in case we decide to go as |
@abnersajr prop can have the default value pointing to the locales, this will give possibility to change the value globally (in locales) or per component (in prop). See for example https://github.com/vuetifyjs/vuetify/blob/master/packages/vuetify/src/components/VAlert/VAlert.ts#L44 |
@abnersajr pulse check on this. |
@johnleider sorry. Things are going crazy this year begin. I will solve it by tomorrow.👊 |
@johnleider @jacekkarczmarczyk all comments done. |
Hey @abnersajr, TravisBuddy Request Identifier: 7e12be80-3d7f-11ea-bf94-57f545f30904 |
I made a mess with the commits, I'm trying to solve this. In case someone have a suggestion please let me know. |
Is this non-breaking? If so, I believe we can get it in as a bug fix seeing as it pertains to a11y. |
Description
This PR adds
aria-*
attributes improving accessibility of the pagination component.Another feature is the component localization with translations to all available locations.
Motivation and Context
It fixes the issue #9849 following all the instructions requested.
How Has This Been Tested?
I manually tested and also the unit test was fixed to work with the new changes.
Markup:
Types of changes
Checklist:
master
for bug fixes and documentation updates,dev
for new features and breaking changes).