Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix(useInfiniteScroll): improve visibility check (#3212)
- Loading branch information
Showing
2 changed files
with
93 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,73 @@ | ||
import { flushPromises } from '@vue/test-utils' | ||
import { describe, expect, it, vi } from 'vitest' | ||
import { ref } from 'vue-demi' | ||
import { useElementVisibility } from '../useElementVisibility' | ||
import { useInfiniteScroll } from '.' | ||
|
||
vi.mock('../useElementVisibility') | ||
describe('useInfiniteScroll', () => { | ||
it('should be defined', () => { | ||
expect(useInfiniteScroll).toBeDefined() | ||
}) | ||
|
||
it.each([ | ||
[ref(givenMockElement())], | ||
[givenMockElement()], | ||
[document], | ||
[window], | ||
])('should calls the loadMore handler, when element is visible', (target) => { | ||
const mockHandler = vi.fn() | ||
givenElementVisibilityRefMock(true) | ||
|
||
useInfiniteScroll(target, mockHandler) | ||
|
||
expect(mockHandler).toHaveBeenCalledTimes(1) | ||
}) | ||
|
||
it('should calls the loadMore handler, when element visibility state form hidden to visible', async () => { | ||
const mockHandler = vi.fn() | ||
const mockElement = givenMockElement() | ||
const visibilityRefMock = givenElementVisibilityRefMock(false) | ||
|
||
useInfiniteScroll(mockElement, mockHandler) | ||
|
||
expect(mockHandler).not.toHaveBeenCalled() | ||
|
||
visibilityRefMock.value = true | ||
await flushPromises() | ||
|
||
expect(mockHandler).toHaveBeenCalledTimes(1) | ||
}) | ||
|
||
it('should call the loadMore handler, when user scrolls', async () => { | ||
const mockElementScrollHeight = 100 | ||
const mockHandler = vi.fn() | ||
const mockElement = givenMockElement({ | ||
scrollHeight: mockElementScrollHeight, | ||
}) | ||
givenElementVisibilityRefMock(true) | ||
|
||
useInfiniteScroll(mockElement, mockHandler) | ||
mockElement.scrollTop = mockElementScrollHeight | ||
mockElement.dispatchEvent(new Event('scroll')) | ||
await flushPromises() | ||
|
||
expect(mockHandler).toHaveBeenCalledTimes(1) | ||
}) | ||
|
||
function givenMockElement({ | ||
scrollHeight = 0, | ||
} = {}): HTMLDivElement { | ||
const mockElement = document.createElement('div') | ||
Object.defineProperty(mockElement, 'scrollHeight', { | ||
value: scrollHeight, | ||
}) | ||
return mockElement | ||
} | ||
|
||
function givenElementVisibilityRefMock(defaultValue: boolean) { | ||
const mockVisibilityRef = ref(defaultValue) | ||
vi.mocked(useElementVisibility).mockReturnValue(mockVisibilityRef) | ||
return mockVisibilityRef | ||
} | ||
}) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters