Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

useVirtualList sometimes missing elements #2065

Closed
7 tasks done
stefnotch opened this issue Aug 9, 2022 · 4 comments · Fixed by #2477
Closed
7 tasks done

useVirtualList sometimes missing elements #2065

stefnotch opened this issue Aug 9, 2022 · 4 comments · Fixed by #2477

Comments

@stefnotch
Copy link
Contributor

Describe the bug

With certain combinations of overscan and low element counts, it can happen that the virtual list is simply missing a few elements.

For example, I tweaked the demo to have an overscan of 1, and the demo list to have 3 elements.
However, it only ends up displaying 2 elements, with no way of seeing the 3rd one.

Reproduction

https://github.com/stefnotch/vueuse/blob/bug-virtual-list/packages/core/useVirtualList/demo.vue

System Info

System:
    OS: Windows 10 10.0.19044
    CPU: (8) x64 Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz
    Memory: 23.74 GB / 31.86 GB
  Binaries:
    Node: 16.14.0 - C:\Program Files\nodejs\node.EXE
    npm: 8.16.0 - C:\Program Files\nodejs\npm.CMD
  Browsers:
    Edge: Spartan (44.19041.1266.0), Chromium (104.0.1293.47)
    Internet Explorer: 11.0.19041.1566

Used Package Manager

pnpm

Validations

@stale
Copy link

stale bot commented Oct 8, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Oct 8, 2022
@stefnotch
Copy link
Contributor Author

The code doesn't seem to have been changed since then, so I'd assume this bug is still present
https://github.com/vueuse/vueuse/commits/main/packages/core/useVirtualList/index.ts

@stale stale bot closed this as completed Oct 16, 2022
@stefnotch
Copy link
Contributor Author

Could this issue be reopened? I can't use the Vueuse virtual list due to this.

@begedin
Copy link
Contributor

begedin commented Nov 25, 2022

I can confirm this is definitely not fixed yet. I think I also see where the bug is, so I will try to submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants