fix(useStyleTag): allow multiline CSS #2476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The current implementation of
useStyleTag
usesel.innerText
to set the<style>
elements content. As per the spec, thisinnerText
method replaces line-breaks with<br>
tags on set, which preventsuseStyleTag
from supporting multi-line CSS as the injected<br>
will break the CSS parsing.From the spec:
This PR replaces innerText with textContent which is text only & doesn't try to interpret the contents.
Additional context
I have updated the demo to show multi-line CSS is supported.
What is the purpose of this pull request?
Before submitting the PR, please make sure you do the following
fixes #123
).