Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(model): prevent _store from becoming a cyclic object value. #11

Merged
merged 1 commit into from
May 9, 2020

Conversation

cuebit
Copy link
Member

@cuebit cuebit commented May 9, 2020

Type of PR:

  • Bugfix
  • Feature
  • Refactor
  • Code style update
  • Build-related changes
  • Test
  • Documentation
  • Other, please describe:

Breaking changes:

  • No
  • Yes

Details

This PR resolves #10 where a fortuitous side-effect is caused by model's exposing the _store property.

@cuebit cuebit requested a review from kiaking May 9, 2020 06:17
@cuebit cuebit self-assigned this May 9, 2020
@codecov
Copy link

codecov bot commented May 9, 2020

Codecov Report

Merging #11 into master will increase coverage by 0.05%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   97.27%   97.32%   +0.05%     
==========================================
  Files          31       31              
  Lines         734      898     +164     
  Branches      105      136      +31     
==========================================
+ Hits          714      874     +160     
- Misses         19       24       +5     
+ Partials        1        0       -1     
Impacted Files Coverage Δ
src/model/Model.ts 94.06% <100.00%> (+0.05%) ⬆️
src/repository/Repository.ts 100.00% <0.00%> (ø)
src/query/Query.ts 95.33% <0.00%> (+0.81%) ⬆️
src/support/Utils.ts 98.00% <0.00%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f45f371...6feee73. Read the comment docs.

@kiaking
Copy link
Member

kiaking commented May 9, 2020

Ahh very good point. Thanks so much for the fix!

@kiaking kiaking merged commit cc98785 into master May 9, 2020
@kiaking kiaking deleted the fix-circular-structure branch May 9, 2020 06:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model exposes the store which is a cyclic object value
2 participants