Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nested relations not getting normalized correctly #50

Merged
merged 1 commit into from
Feb 24, 2021

Conversation

kiaking
Copy link
Member

@kiaking kiaking commented Feb 24, 2021

This PR fixes the nested relationship normalization error.

Type of PR:

  • Bugfix
  • Feature
  • Refactor
  • Code style update
  • Build-related changes
  • Test
  • Documentation
  • Other, please describe:

Breaking changes:

  • No
  • Yes

@kiaking kiaking added the bug Something isn't working label Feb 24, 2021
@kiaking kiaking self-assigned this Feb 24, 2021
@codecov
Copy link

codecov bot commented Feb 24, 2021

Codecov Report

Merging #50 (20fe89d) into master (f82488a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #50   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           36        36           
  Lines          822       823    +1     
  Branches       131       132    +1     
=========================================
+ Hits           822       823    +1     
Impacted Files Coverage Δ
src/model/Model.ts 100.00% <100.00%> (ø)
src/model/attributes/relations/BelongsTo.ts 100.00% <100.00%> (ø)
src/model/attributes/relations/HasMany.ts 100.00% <100.00%> (ø)
src/model/attributes/relations/HasManyBy.ts 100.00% <100.00%> (ø)
src/model/attributes/relations/HasOne.ts 100.00% <100.00%> (ø)
src/schema/Schema.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f82488a...20fe89d. Read the comment docs.

@kiaking kiaking merged commit ea6203b into master Feb 24, 2021
@kiaking kiaking deleted the fix-nested-relation-normalization-error branch February 24, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant