Assert using Hex value

[mauvesea]

gfx/footprints.asm uses $100 for assert, instead of using a constant like NUM_POKEMON.

[aaaaaa123456789]

This is not a simple issue, because the codebase actually expects $100 as written, even though NUM_POKEMON is less than $100. Maybe the solution is to fix the code so there's no unused padding.

[Rangi42]

Yeah, fixing the design flaw would be appropriate, like the many applied bugfixes which were relevant to the 16-bit features.

[vulcandth]

Yeah, fixing the design flaw would be appropriate, like the many applied bugfixes which were relevant to the 16-bit features.

That design flaw was already fixed in @aaaaaa123456789 's commit 03414e5.

[Rangi42]

Great, then yes, the extra footprints are no longer necessary.

[vulcandth]

This has been resolved in the latest rebase.